From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.bugs Subject: Re: backup-buffer-copy loops if old backup can't be deleted Date: Fri, 24 Aug 2007 08:11:35 +0200 Message-ID: <18126.30359.22175.276557@a1ihome1.kph.uni-mainz.de> References: <46CAD810.3050904@gmx.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1187935930 20667 80.91.229.12 (24 Aug 2007 06:12:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 24 Aug 2007 06:12:10 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, Martin von Gagern To: Richard Stallman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 24 08:12:06 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IOSOs-0002Aq-GH for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Aug 2007 08:12:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IOSOp-0004yf-KF for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Aug 2007 02:12:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IOSOn-0004wx-EB for bug-gnu-emacs@gnu.org; Fri, 24 Aug 2007 02:12:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IOSOl-0004wh-Rl for bug-gnu-emacs@gnu.org; Fri, 24 Aug 2007 02:12:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IOSOl-0004we-Od for bug-gnu-emacs@gnu.org; Fri, 24 Aug 2007 02:11:59 -0400 Original-Received: from mail.kph.uni-mainz.de ([134.93.132.3]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IOSOb-0004sK-Qn; Fri, 24 Aug 2007 02:11:50 -0400 Original-Received: from a1ihome1.kph.uni-mainz.de (a1ihome1.kph.uni-mainz.de [134.93.134.75]) by mail.kph.uni-mainz.de (8.12.9p2/8.12.9) with ESMTP id l7O6Bi0E081642; Fri, 24 Aug 2007 08:11:44 +0200 (CEST) (envelope-from ulm@kph.uni-mainz.de) Original-Received: from a1ihome1.kph.uni-mainz.de (localhost [127.0.0.1]) by a1ihome1.kph.uni-mainz.de (8.13.8/8.13.4) with ESMTP id l7O6BhcX032015; Fri, 24 Aug 2007 08:11:43 +0200 Original-Received: (from ulm@localhost) by a1ihome1.kph.uni-mainz.de (8.14.1/8.14.1/Submit) id l7O6Bh50032008; Fri, 24 Aug 2007 08:11:43 +0200 X-Mailer: VM 8.0.1-465 under Emacs 22.1.1 (i686-pc-linux-gnu) X-Detected-Kernel: FreeBSD 4.6-4.9 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16432 Archived-At: >>>>> On Thu, 23 Aug 2007, Richard Stallman wrote: > I think that fix is actually correct. > So this change should be installed. It has been installed, but ... > I think there is no need to explicitly check whether the directory > is writable. What would be the purpose of that? ... the previous change was not completely reverted, variable "dir" still gets assigned but is not used. So the following patch should be applied in addition: --- files.el 24 Aug 2007 03:03:52 -0000 1.922 +++ files.el 13 Aug 2007 13:40:58 -0000 1.919 @@ -3172,9 +3172,7 @@ (file-error nil)))))) (defun backup-buffer-copy (from-name to-name modes) - (let ((umask (default-file-modes)) - (dir (or (file-name-directory to-name) - default-directory))) + (let ((umask (default-file-modes))) (unwind-protect (progn ;; Create temp files with strict access rights. It's easy to