From: Ulrich Mueller <ulm@gentoo.org>
To: Richard Stallman <rms@gnu.org>
Cc: bug-gnu-emacs@gnu.org, Martin von Gagern <Martin.vGagern@gmx.net>
Subject: Re: backup-buffer-copy loops if old backup can't be deleted
Date: Fri, 24 Aug 2007 08:11:35 +0200 [thread overview]
Message-ID: <18126.30359.22175.276557@a1ihome1.kph.uni-mainz.de> (raw)
In-Reply-To: mailman.5219.1187902794.32220.bug-gnu-emacs@gnu.org
>>>>> On Thu, 23 Aug 2007, Richard Stallman wrote:
> I think that fix is actually correct.
> So this change should be installed.
It has been installed, but ...
> I think there is no need to explicitly check whether the directory
> is writable. What would be the purpose of that?
... the previous change was not completely reverted, variable "dir"
still gets assigned but is not used.
So the following patch should be applied in addition:
--- files.el 24 Aug 2007 03:03:52 -0000 1.922
+++ files.el 13 Aug 2007 13:40:58 -0000 1.919
@@ -3172,9 +3172,7 @@
(file-error nil))))))
(defun backup-buffer-copy (from-name to-name modes)
- (let ((umask (default-file-modes))
- (dir (or (file-name-directory to-name)
- default-directory)))
+ (let ((umask (default-file-modes)))
(unwind-protect
(progn
;; Create temp files with strict access rights. It's easy to
next prev parent reply other threads:[~2007-08-24 6:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.5018.1187641790.32220.bug-gnu-emacs@gnu.org>
2007-08-20 22:01 ` backup-buffer-copy loops if old backup can't be deleted Martin von Gagern
[not found] ` <mailman.5021.1187647310.32220.bug-gnu-emacs@gnu.org>
2007-08-21 12:18 ` Martin von Gagern
2007-08-21 14:37 ` martin rudalics
2007-08-21 14:51 ` Martin von Gagern
2007-08-21 15:28 ` martin rudalics
2007-08-21 19:35 ` Glenn Morris
2007-08-21 21:01 ` martin rudalics
2007-08-21 21:50 ` Glenn Morris
2007-08-22 9:13 ` Martin von Gagern
2007-08-22 9:44 ` martin rudalics
2007-08-22 9:48 ` Martin von Gagern
2007-08-22 12:40 ` martin rudalics
2007-08-22 21:37 ` Michael Schierl
2007-08-21 22:21 ` Martin von Gagern
2007-08-22 9:51 ` Ulrich Mueller
2007-08-23 20:59 ` Richard Stallman
2007-08-24 7:13 ` Martin von Gagern
2007-08-24 9:10 ` martin rudalics
2007-08-25 4:07 ` Richard Stallman
2007-08-25 4:07 ` Richard Stallman
[not found] ` <mailman.5219.1187902794.32220.bug-gnu-emacs@gnu.org>
2007-08-24 6:11 ` Ulrich Mueller [this message]
2007-08-20 19:58 Martin von Gagern
2007-08-21 6:50 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18126.30359.22175.276557@a1ihome1.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=Martin.vGagern@gmx.net \
--cc=bug-gnu-emacs@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).