From: Ulrich Mueller <ulm@gentoo.org>
To: Martin von Gagern <Martin.vGagern@gmx.net>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: backup-buffer-copy loops if old backup can't be deleted
Date: Wed, 22 Aug 2007 11:51:52 +0200 [thread overview]
Message-ID: <18124.1848.964776.264332@a1ihome1.kph.uni-mainz.de> (raw)
In-Reply-To: <46CB6586.9050005@gmx.net>
>>>>> On Wed, 22 Aug 2007, Martin von Gagern wrote:
> I can think of at least two scenarios where this could be a problem:
> 1. The dir is not writable, but the backup file is. Here the current
> behaviour will loop and even with the suggested fix it will fall
> back to ~/%backup%~ unnecessarily.
> [...]
> I originally assumed that emacs would try backup-buffer-copy only
> after figuring out that it could not write to the existing backup
> file, but it seems I was wrong there, at least if I read
> backup-buffer correctly.
It seems that your assumption is the intended behaviour. At least the
problem was noticed and a fix was installed in March 2005:
<http://lists.gnu.org/archive/html/emacs-devel/2005-03/msg00842.html>
However, it no longer works due to the introduction of the loop in
backup-buffer-copy one month later (this change was in CVS revision
1.757 of files.el). The relevant part is:
(defun backup-buffer-copy (from-name to-name modes)
- (condition-case ()
- (copy-file from-name to-name t t)
- (file-error
- ;; If copying fails because file TO-NAME
- ;; is not writable, delete that file and try again.
- (if (and (file-exists-p to-name)
- (not (file-writable-p to-name)))
- (delete-file to-name))
- (copy-file from-name to-name t t)))
+ (let ((umask (default-file-modes)))
+ (unwind-protect
+ (progn
+ ;; Create temp files with strict access rights. It's easy to
+ ;; loosen them later, whereas it's impossible to close the
+ ;; time-window of loose permissions otherwise.
+ (set-default-file-modes ?\700)
+ (while (condition-case ()
+ (progn
+ (condition-case nil
+ (delete-file to-name)
+ (file-error nil))
+ (write-region "" nil to-name nil 'silent nil 'excl)
+ nil)
+ (file-already-exists t))
+ ;; the file was somehow created by someone else between
+ ;; `make-temp-name' and `write-region', let's try again.
+ nil)
+ (copy-file from-name to-name t t 'excl))
+ ;; Reset the umask.
+ (set-default-file-modes umask)))
(and modes
(set-file-modes to-name (logand modes #o1777))))
with the following ChangeLog entry:
2005-04-23 Richard M. Stallman <rms@gnu.org>
* files.el [...]
(backup-buffer-copy, basic-save-buffer-2): Take care against
writing thru an unexpected existing symlink.
[...]
There should be easier ways to achieve protection against writing
through symlinks.
Ulrich
next prev parent reply other threads:[~2007-08-22 9:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.5018.1187641790.32220.bug-gnu-emacs@gnu.org>
2007-08-20 22:01 ` backup-buffer-copy loops if old backup can't be deleted Martin von Gagern
[not found] ` <mailman.5021.1187647310.32220.bug-gnu-emacs@gnu.org>
2007-08-21 12:18 ` Martin von Gagern
2007-08-21 14:37 ` martin rudalics
2007-08-21 14:51 ` Martin von Gagern
2007-08-21 15:28 ` martin rudalics
2007-08-21 19:35 ` Glenn Morris
2007-08-21 21:01 ` martin rudalics
2007-08-21 21:50 ` Glenn Morris
2007-08-22 9:13 ` Martin von Gagern
2007-08-22 9:44 ` martin rudalics
2007-08-22 9:48 ` Martin von Gagern
2007-08-22 12:40 ` martin rudalics
2007-08-22 21:37 ` Michael Schierl
2007-08-21 22:21 ` Martin von Gagern
2007-08-22 9:51 ` Ulrich Mueller [this message]
2007-08-23 20:59 ` Richard Stallman
2007-08-24 7:13 ` Martin von Gagern
2007-08-24 9:10 ` martin rudalics
2007-08-25 4:07 ` Richard Stallman
2007-08-25 4:07 ` Richard Stallman
[not found] ` <mailman.5219.1187902794.32220.bug-gnu-emacs@gnu.org>
2007-08-24 6:11 ` Ulrich Mueller
2007-08-20 19:58 Martin von Gagern
2007-08-21 6:50 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18124.1848.964776.264332@a1ihome1.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=Martin.vGagern@gmx.net \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).