From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#53935: 27.2; [PATCH] ecomplete.el: Auto-select when there is only a single option Date: Fri, 11 Feb 2022 21:28:16 +1300 Message-ID: <1800d942d3cdf963c15cd970ba64bd37@webmail.orcon.net.nz> References: <1d908e97443d75dcb94e1e7c9fdcfb79@webmail.orcon.net.nz> <87o83d6hlg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17778"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: 53935@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 11 09:30:02 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIRJa-0004Tf-Ph for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Feb 2022 09:30:02 +0100 Original-Received: from localhost ([::1]:57240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIRJX-0004uV-IF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Feb 2022 03:30:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIRId-0004tE-1o for bug-gnu-emacs@gnu.org; Fri, 11 Feb 2022 03:29:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36057) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nIRIc-0008U6-OK for bug-gnu-emacs@gnu.org; Fri, 11 Feb 2022 03:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nIRIc-0001SB-E0 for bug-gnu-emacs@gnu.org; Fri, 11 Feb 2022 03:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Feb 2022 08:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53935-submit@debbugs.gnu.org id=B53935.16445681005537 (code B ref 53935); Fri, 11 Feb 2022 08:29:02 +0000 Original-Received: (at 53935) by debbugs.gnu.org; 11 Feb 2022 08:28:20 +0000 Original-Received: from localhost ([127.0.0.1]:58187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIRHw-0001RF-51 for submit@debbugs.gnu.org; Fri, 11 Feb 2022 03:28:20 -0500 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:58265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIRHu-0001R7-9z for 53935@debbugs.gnu.org; Fri, 11 Feb 2022 03:28:19 -0500 Original-Received: from [10.253.37.70] (port=58188 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1nIRHs-0002av-DD; Fri, 11 Feb 2022 21:28:16 +1300 Original-Received: from ip-139-180-65-103.kinect.net.nz ([139.180.65.103]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 11 Feb 2022 21:28:16 +1300 In-Reply-To: <87o83d6hlg.fsf@gnus.org> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226651 Archived-At: On 2022-02-11 19:30, Lars Ingebrigtsen wrote: > ecomplete tries to emulate how these things work in major browsers, > and they do not work this way (autoselect when there's only one > match) -- because the user may be typing to see what's available, > and would then remove some characters if they don't get the matches > they're looking for. They can still do all of that, just as before. The "automated" part of my patch happens *after* the user has finished adding/removing characters, and has explicitly said (via M-n) that they now wish to choose from one of the visible completion options. The only difference between the old and new behaviour is that, in cases where they'd filtered the completion options down to a single option, they no longer have to additionally (and redundantly) type RET after M-n to select the only thing that they could possibly select. ("M-n" acts like the sequence "M-n RET", in other words.) -Phil