From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#64391: buffer narrowing slowdown regression in emacs 29 Date: Sun, 09 Jul 2023 16:04:09 +0000 Message-ID: <17bc5861306adf83809a@heytings.org> References: <87r0psb51z.fsf@ust.hk> <0AD15A09-F669-48C0-AF5C-971D52F5BF8E@gmail.com> <83v8f3q1ff.fsf@gnu.org> <50A46AAC-2089-45CB-A355-CCB2B4EA8D76@gmail.com> <5995c9ed6a0b39c3070c@heytings.org> <83a5wak1tr.fsf@gnu.org> <26cee506f708f3c6cfe1@heytings.org> <26cee506f70bbc9de58b@heytings.org> <83h6qghpdc.fsf@gnu.org> <26cee506f77e9c87e325@heytings.org> <06A8380F-08A6-464E-9946-02F8498031EC@gmail.com> <239e2a5aa11924a2f1d3@heytings.org> <239e2a5aa14d33c1b087@heytings.org> <83jzv9bp0a.fsf@gnu.org> <17bc5861309c808fe41c@heytings.org> <831qhhbh60.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22842"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 09 18:05:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIWuN-0005eO-7o for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jul 2023 18:05:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIWuH-0001IF-G4; Sun, 09 Jul 2023 12:05:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIWuE-0001Gn-VT for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 12:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIWuE-0003vK-MX for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 12:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qIWuE-0003dh-G1; Sun, 09 Jul 2023 12:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 09 Jul 2023 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64391 X-GNU-PR-Package: emacs,gnus X-Debbugs-Original-Cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca, bugs@gnus.org Original-Received: via spool by 64391-submit@debbugs.gnu.org id=B64391.168891865313920 (code B ref 64391); Sun, 09 Jul 2023 16:05:02 +0000 Original-Received: (at 64391) by debbugs.gnu.org; 9 Jul 2023 16:04:13 +0000 Original-Received: from localhost ([127.0.0.1]:46998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIWtR-0003cR-07 for submit@debbugs.gnu.org; Sun, 09 Jul 2023 12:04:13 -0400 Original-Received: from heytings.org ([95.142.160.155]:47656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIWtO-0003cH-Jp for 64391@debbugs.gnu.org; Sun, 09 Jul 2023 12:04:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1688918650; bh=qVBwjNc/8lenDhGX9mprZq74x1FyQdsH32RZlYZiJqo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=3eJVVaBzMha1bo2WwBXb0Bwv5r2yyXgB5P1u2+7qgcY+5/bj07TFDho+lFDsmwv5g UJcDsHLrJj08M/IUGet+k//xVLDL2KQ9C+v84RCidqeQylp/N7AsIehdCr0B7MFHhl 0R7J6KJNyJ1CuMvmWB3J8WjdDlxCmdiivR10lbp0T2wFOX+gWA9K/Dfy6KTN5RKXUf jEuI9eHbBvcnDs77sG4dLR2fBVFhPugwdmiOR+7IfdAJ3qZoHghF23bj/vv75eu/6w l0kxtJSZmbsfgFDqCl47nnJGv6f/OJs1nX4ODs2o9+q4GhQ3IsWcmbvCv7w9LSOADC 2AfgAKm573amw== In-Reply-To: <831qhhbh60.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264843 Archived-At: >>> I also question the wisdom of telling only in the doc string that the >>> tag is evaluated. I could understand if you did that the other way >>> around, but if the doc string says that, the manual should also say >>> it. >> >> But the patch I sent changes both the manual and the docstring? > > It does, but only the latter says that LABEL is evaluated. > Oh, indeed, now I see what you mean. Here's the updated patch. On a second thought, I believe its better to not replace LABEL with TAG, because that would mean changing that word in many places, including places in which such a change would make the text less understandable, e.g. the docstring of narrow-to-region: However, when restrictions have been set by `with-restriction' with a label, `narrow-to-region' can be used only within the limits of these restrictions. If the START or END arguments are outside these limits, the corresponding limit set by `with-restriction' is used instead of the argument. To gain access to other portions of the buffer, use `without-restriction' with the same label. diff --git a/doc/lispref/positions.texi b/doc/lispref/positions.texi index e74a165b9ed..183d0e39aee 100644 --- a/doc/lispref/positions.texi +++ b/doc/lispref/positions.texi @@ -1169,9 +1169,10 @@ Narrowing @cindex labeled narrowing @cindex labeled restriction -When the optional argument @var{label}, a symbol, is present, the -narrowing is @dfn{labeled}. A labeled narrowing differs from a -non-labeled one in several ways: +When the optional argument @var{label}, which is evaluated to get the +label to use and must not be @code{nil}, is present, the narrowing is +@dfn{labeled}. A labeled narrowing differs from a non-labeled one in +several ways: @itemize @bullet @item diff --git a/lisp/subr.el b/lisp/subr.el index 0b397b7bebf..2f0144e0f11 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -3964,11 +3964,11 @@ with-restriction The current restrictions, if any, are restored upon return. -When the optional :label LABEL argument is present, in which -LABEL is a symbol, inside BODY, `narrow-to-region' and `widen' -can be used only within the START and END limits. To gain access -to other portions of the buffer, use `without-restriction' with the -same LABEL argument. +When the optional LABEL argument, which is evaluated to get the +label to use and must not be nil, is present, inside BODY, +`narrow-to-region' and `widen' can be used only within the START +and END limits. To gain access to other portions of the buffer, +use `without-restriction' with the same LABEL argument. \(fn START END [:label LABEL] BODY)" (declare (indent 2) (debug t)) @@ -3990,9 +3990,8 @@ without-restriction The current restrictions, if any, are restored upon return. -When the optional :label LABEL argument is present, the -restrictions set by `with-restriction' with the same LABEL argument -are lifted. +When the optional LABEL argument is present, the restrictions set +by `with-restriction' with the same LABEL argument are lifted. \(fn [:label LABEL] BODY)" (declare (indent 0) (debug t))