From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#27840: 26.0.50; vc-git-grep stopped working on git master Date: Tue, 1 Aug 2017 16:36:17 +0300 Message-ID: <17696669-9155-d7d2-ffe3-97bb62ceb733@yandex.ru> References: <87shhj3wtc.fsf@pokyo> <87inie93lp.fsf@users.sourceforge.net> <07272ad0-8cd0-f75e-1cf7-8f66e1d77466@yandex.ru> <8760e994rv.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1501594633 830 195.159.176.226 (1 Aug 2017 13:37:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2017 13:37:13 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Thunderbird/55.0 Cc: 27840@debbugs.gnu.org, Tom Tromey To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 01 15:37:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXM9-0008Gt-4Q for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Aug 2017 15:37:05 +0200 Original-Received: from localhost ([::1]:42606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcXMF-0001f9-8m for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Aug 2017 09:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcXM9-0001f3-JM for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 09:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcXM6-0004Ux-9J for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 09:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33584) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcXM6-0004Un-3a for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 09:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dcXM5-0005h5-TT for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 09:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2017 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27840 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27840-submit@debbugs.gnu.org id=B27840.150159458721845 (code B ref 27840); Tue, 01 Aug 2017 13:37:01 +0000 Original-Received: (at 27840) by debbugs.gnu.org; 1 Aug 2017 13:36:27 +0000 Original-Received: from localhost ([127.0.0.1]:36261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXLW-0005gH-MW for submit@debbugs.gnu.org; Tue, 01 Aug 2017 09:36:26 -0400 Original-Received: from mail-wm0-f66.google.com ([74.125.82.66]:34549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXLU-0005g0-SL for 27840@debbugs.gnu.org; Tue, 01 Aug 2017 09:36:25 -0400 Original-Received: by mail-wm0-f66.google.com with SMTP id x64so3104008wmg.1 for <27840@debbugs.gnu.org>; Tue, 01 Aug 2017 06:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dCUdrpL9RnMZON/MGvcU77WkLKc0EAeV7KKb2XZiyV8=; b=Jx4wLy70HWl86rtPlijU7vHeR1oo06j1js5soCEMh9TQBhy6NW3PK5GBnrdOXKsN75 NZO0Q5RB76550ybCoUhgjxyFWJaQurKE5IAiu5gTI/fnjPrGmqGa2xAWo+s/pggyzmZP ZPBCGUCJHYeDZM1SDxXLdBzqWcGuaUO5Fx3l//PgpXEQsDY+YlexmJYeu4Yk+I3Kqgb/ nvU4E+m8Eluk9BqeqiC1SZZc8naXyx3tcxNW982rX4rMWuSRkFumk+A2k7f4QtW0XUa0 0wZylkhN61LrOMt5TJEiKpaZ6oUK9VueL011hwCW1LRHEYNXegejqf5S4USNNOFnlpYe QHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dCUdrpL9RnMZON/MGvcU77WkLKc0EAeV7KKb2XZiyV8=; b=uRNwbN2mwlmp7VDrvxVvBrFXRtpLzF7/AZ/bLjY+j5dkgpHOuwYGWG7fPmNiS5VexO MjC36viJKkNe7ECCYTB9B2JRZRB71LGxEbKsJJY0SnOU6SwxHcAn0S8hEy0geVoBgIiP IZhf2vIEn4ZIk6DWYoKhjLo+ZxyF3lDsyp7vtybrp396bPlFdCFq5qDI+0bflOEvqEyG VUhXF7kcYPP/1tLARFJjlkj3ykK9StkgWOjMqP7Phs+goJ1EQAUwwq4voa9T/JmdCzcG GGivvkqbrHZemMmSwkcMWQyqVoQztswmDgvwZW6i2GNVarPa5M08wEXVkCTzA0I2T6JX uzsg== X-Gm-Message-State: AIVw113pmic9fHRAsjVT1RsyU4ht8upFriCwQrmVFvZ67RFscxW2qOTZ BcuxMdKPulERcQ== X-Received: by 10.80.168.34 with SMTP id j31mr17771707edc.87.1501594579270; Tue, 01 Aug 2017 06:36:19 -0700 (PDT) Original-Received: from [192.168.0.133] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id f11sm4424709ede.57.2017.08.01.06.36.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 06:36:18 -0700 (PDT) In-Reply-To: <8760e994rv.fsf@users.sourceforge.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135211 Archived-At: On 7/30/17 9:08 PM, npostavs@users.sourceforge.net wrote: > Right, but the question is: are there n+1 other places where we will > need to do this? I don't know. If we really want the default settings of grep-mode to fit all grep-like programs, then the task is suddenly harder, and we do want to default to the non-null. Although, honestly, in that case, I would consider reverting the patch, because it increases complexity, yet is unlikely (as non-default) to be used by the majority of the users. Alternatively, one regexp would have to handle both versions, with and without null (merging grep-with-null-regexp-alist and grep-fallback-regexp-alist together, if it's at all possible).