From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#57635: 29.0.50; Look into using generator.el's CPS machinery to replace 'eshell-do-eval' Date: Tue, 6 Sep 2022 20:58:00 -0700 Message-ID: <1766577e-022f-87ae-873e-875d84078891@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32024"; mail-complaints-to="usenet@ciao.gmane.io" To: 57635@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 07 05:59:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVmDW-0008DA-2J for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Sep 2022 05:59:10 +0200 Original-Received: from localhost ([::1]:56754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVmDV-0006P5-32 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 23:59:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVmDP-0006Ow-AA for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 23:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVmDP-0002As-1p for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 23:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVmDO-00018d-P7 for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 23:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Sep 2022 03:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57635 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16625230864273 (code B ref -1); Wed, 07 Sep 2022 03:59:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Sep 2022 03:58:06 +0000 Original-Received: from localhost ([127.0.0.1]:53112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVmCU-00016r-Fg for submit@debbugs.gnu.org; Tue, 06 Sep 2022 23:58:06 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:56618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVmCS-00016k-Op for submit@debbugs.gnu.org; Tue, 06 Sep 2022 23:58:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVmCS-0006In-JL for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 23:58:04 -0400 Original-Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:35367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVmCQ-00022J-Le for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 23:58:04 -0400 Original-Received: by mail-pf1-x435.google.com with SMTP id 123so3964364pfy.2 for ; Tue, 06 Sep 2022 20:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:mime-version:date :message-id:to:subject:from:from:to:cc:subject:date; bh=3/Q7dSUW/X7y1bx8J5aM0LNFJmOwLauFM5DPy5rvB8Y=; b=DCwDCK7V4E05qc5bS9ajx/iaAhd5v1rt2Gha9fn8nGeCDtCJ+qcVo7UuPGy90fr9xG TJxLxaT5vwq590bG4hICqXVqhyiL+fzKCkEvrYf9t7/OEM0l2DJF8iD7AWMnD4H/EG6V oRP74PEPTDXKdIz8S+Yi+01qhkZfjAWnXVq28INDaL0m88mp3OQJF7aRNbFX6A34Ftig xq8tH6W/VVCdIoK7M+/Y/mHm/ZYxfsMo/X8P+njC9YKSZkOLFVZRlZUCuJt+tWzgcxDq EoNRAEPxgza/7kvMCwgCLR0QFjSU1a3p+1ahlQeoaBaYs5BEbMtSmTLioYM9cJ22sRtv uSvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:mime-version:date :message-id:to:subject:from:x-gm-message-state:from:to:cc:subject :date; bh=3/Q7dSUW/X7y1bx8J5aM0LNFJmOwLauFM5DPy5rvB8Y=; b=ECjtEGYLIBSg3V3I9alm1gNtiobyKgB5klRmeQsjqwPONGZWE/Fyx+sm/sgDBJGwG5 3nyAriuzH97HVFdH9m49rKhvAhu/pyUyHvfuuCRr4U28IVKMn2WneaSb/Q+K2A+Bp1zK 53ZGG0A8uz4+PYfDncbAzWyNXQ2fgvsjlBcO7JVyNnNxFx5kD/KPrWgq2iNIiq4XIitf zeZ8y9V3/6N4ckrZf/kakM3xVDQiW+8ynkOcl7GI+DWSU/q0B8x62Ee3azv74r4KSex7 I+sGQyFnam3u9rpZLQIPZqkh4pYI3tfm5fD1+QUbAk45s5xTMvx5OmqKs+3YmzYk9OCc bfRQ== X-Gm-Message-State: ACgBeo3UpYDDhJ2ApFwz2Qar6NJjA2Na4pIMW9kXMM/n1HpAC7QyyNC/ xm8NYFtq3b+qsYXWK/hcgjvNKX5iE9w= X-Google-Smtp-Source: AA6agR6CqWIhhqaz3w2BpTRWrl07WrKrhWFYcGqs4w0FM9OhI3hm15k7Xqw/jLr8dAKBzdGd9X1LNg== X-Received: by 2002:a63:6643:0:b0:42b:c05e:e3a9 with SMTP id a64-20020a636643000000b0042bc05ee3a9mr1650520pgc.513.1662523081010; Tue, 06 Sep 2022 20:58:01 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 5-20020a17090a190500b001fe444b2245sm9822931pjg.25.2022.09.06.20.57.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 20:58:00 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.org:119 Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241720 Archived-At: In order to make long-running Eshell commands behave more-nicely, Eshell uses iterative evaluation of many commands so that it can return control back to the rest of Emacs. This has a lot of similarity to how generator.el works. This would hopefully help prevent obscure bugs in Eshell, such as bug#54190. In that bug, Stefan mentions[1]: > Looks like a bug somewhere in the `eshell-do-eval` machinery, yes. > Until we find the problem (or rewrite `eshell-do-eval` on top of the CPS > converter of `generator.el`), I think reverting this change (and adding > a comment pointing to this bug) sounds like a great plan. [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54190#17