From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#60423: 29.0.60; goto-address and shr/textsec don't play nicely together Date: Thu, 29 Dec 2022 19:59:05 -0800 Message-ID: <175894.1672372745@alto> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40775"; mail-complaints-to="usenet@ciao.gmane.io" To: 60423@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 30 08:04:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pB9RU-000AJk-9W for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Dec 2022 08:04:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pB9RF-0004af-PM; Fri, 30 Dec 2022 02:04:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pB9R3-0004Xe-KU for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 02:04:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pB9R1-000608-CJ for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 02:04:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pB9R1-0006Eb-7b for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 02:04:07 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Dec 2022 07:04:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60423 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167238382223814 (code B ref -1); Fri, 30 Dec 2022 07:04:07 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Dec 2022 07:03:42 +0000 Original-Received: from localhost ([127.0.0.1]:33445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB9Qb-0006Bw-Or for submit@debbugs.gnu.org; Fri, 30 Dec 2022 02:03:42 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:59390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB6YE-0001KV-37 for submit@debbugs.gnu.org; Thu, 29 Dec 2022 22:59:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pB6YD-0001EB-Tn for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 22:59:21 -0500 Original-Received: from shell1.rawbw.com ([198.144.192.42]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pB6YB-0007Le-Ma for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 22:59:21 -0500 Original-Received: from alto (135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 2BU3x5Fd017250 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 29 Dec 2022 19:59:10 -0800 (PST) (envelope-from kupfer@rawbw.com) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged) claimed to be alto X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.60 Received-SPF: pass client-ip=198.144.192.42; envelope-from=kupfer@rawbw.com; helo=shell1.rawbw.com X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, HTTPS_HTTP_MISMATCH=0.1, PDS_SHORT_SPOOFED_URL=1.997, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 30 Dec 2022 02:03:35 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252092 Archived-At: --=-=-= Content-Type: text/plain View the HTML portion of the attached email in MH-E and Gnus. Both will display "https://fsf.org" in red and put a caution emoji after it, because the link doesn't actually point to https://fsf.org. Good so far. In Gnus, if you mouse over the link, the actual target appears in the echo area. And if you mouse over the caution emoji, you'll see text in the echo area that tells you that the link target doesn't match the link text. Also good so far. In MH-E, if you mouse over the link or emoji, you get text in the echo area that tells you how to follow the link. There's no explanation given for the red text or the caution emoji, which is a bug IMO. I tracked this down to MH-E's use of goto-address when displaying a message (mh-display-msg > mh-show-addr > goto-address). I can think of a couple ways to deal with this, but I'm not sure what the right way forward is. The simplest approach would be for mh-display-msg to stop using goto-address. I'm not happy with that approach because it removes functionality that MH-E has had for awhile. A slightly more sophisticated approach would be to not use goto-address when using shr to render the message. That loses some functionality (like the auto-linkification of email addresses), and it seems kind of kludgey, but I suppose it's not too terrible. Another possibility would be to make goto-address smarter, so that it doesn't stomp on whatever it was that shr did to get the mouse-over text. I'm happy to take a stab at a fix, but I could use some guidance on the right direction to go in. thanks, mike --=-=-= Content-Type: text/html Content-Disposition: attachment; filename=5 Content-Description: test case email Subject: test case From: nobody@nowhere.org To: J. Random User Date: Mon, 20 Jun 2022 21:40:46 +0000 Content-Type: multipart/alternative; boundary="_----------=_MCPart_63361485" MIME-Version: 1.0 This is a multi-part message in MIME format --_----------=_MCPart_63361485 Content-Type: text/plain; charset="utf-8"; format="fixed" [23oct22: deleted -mdk] --_----------=_MCPart_63361485 Content-Type: text/html; charset="utf-8"

This link is okay, as is https://fsf.org.

But this one is not: https://fsf.org.

goto-address will linkify foo@bar.com, but shr does not.

--_----------=_MCPart_63361485-- --=-=-= Content-Type: text/plain PS. I've reproduced the problem with commit a14821d615; you can ignore the "Repository revision" and "Repository branch" fields below. In GNU Emacs 29.0.60 (build 4, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2022-12-29 built on alto Repository revision: f26689637923ac9b834a209e1bab09c779be212f Repository branch: emacs-29-mdk Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --prefix=/usr/new' Configured features: CAIRO FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM LUCID ZLIB Important settings: value of $LC_TIME: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: MH-Folder Minor modes in effect: hl-line-mode: t shell-dirtrack-mode: t delete-selection-mode: t global-eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t buffer-read-only: t column-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow mh-identity mh-letter emacsbug sort gnus-async gnus-bcklg gnus-kill qp cl-extra help-mode gnus-ml disp-table url-http url-gw url-cache url-auth url-handlers nnrss mm-url nndoc nndraft network-stream nsm gnus-agent gnus-srvr nnvirtual nntp gnus-cache textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check mm-archive mail-extr mh-mime mule-util mh-thread mh-show goto-addr gnus-cite mh-inc hl-line mh-tool-bar mh-acros mh-seq mh-xface mh-utils mh-folder which-func imenu misearch multi-isearch crm thingatpt cus-edit pp cus-start cus-load mdk-mail gnus-mh gnus-msg mh-comp mh-scan mh-gnus gnus-dup nnmh gnus-score score-mode gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs json map gv url-vars gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win gnus nnheader range wid-edit mh-e mh-buffers mh-loaddefs message sendmail mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader warnings server noutline outline icons cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs byte-opt bytecomp byte-compile shell subr-x pcomplete comint ansi-osc ansi-color ring xcscope advice delsel vc vc-dispatcher timeclock cl-loaddefs cl-lib mdk-hacks rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 350237 71147) (symbols 48 23107 9) (strings 32 88955 27698) (string-bytes 1 2387295) (vectors 16 66600) (vector-slots 8 1547532 240746) (floats 8 253 414) (intervals 56 767 0) (buffers 976 22)) --=-=-=--