From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#63385: 30.0.50; [DRAFT PATCH v1] Update eshell defcustom definitions Date: Sun, 14 May 2023 21:39:55 -0700 Message-ID: <1750da77-a6c2-dc6d-53ef-fba3e0f68034@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24755"; mail-complaints-to="usenet@ciao.gmane.io" To: Ruijie Yu , 63385@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 15 06:41:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyQ1W-0006MR-TD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 May 2023 06:41:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyQ1D-0003pl-R1; Mon, 15 May 2023 00:41:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyQ19-0003pA-Nn for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 00:41:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyQ18-0007Ka-HL for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 00:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyQ18-0006UI-E6 for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 00:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 May 2023 04:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63385 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63385-submit@debbugs.gnu.org id=B63385.168412560424847 (code B ref 63385); Mon, 15 May 2023 04:41:02 +0000 Original-Received: (at 63385) by debbugs.gnu.org; 15 May 2023 04:40:04 +0000 Original-Received: from localhost ([127.0.0.1]:42439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyQ0B-0006Sf-DE for submit@debbugs.gnu.org; Mon, 15 May 2023 00:40:03 -0400 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:48178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyQ09-0006S7-L1 for 63385@debbugs.gnu.org; Mon, 15 May 2023 00:40:02 -0400 Original-Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-643846c006fso13023264b3a.0 for <63385@debbugs.gnu.org>; Sun, 14 May 2023 21:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684125596; x=1686717596; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=rqD9lCkTIuxXh8EyE/Au4wyqwPHCiGeE6RebyCPkCgE=; b=Ly0pbzVDLlkFwt6LnfeqC+dZe2wVewoFTNPiXpXl5LeEKaQ02F2YTJ84XIK610I/cs c63JtQIPZE4/J6SiRWkc/aHN6LpatxR2vD478xKGKoI7SUy3kWynGZEOVHiQJp/MGihK 894OrI7qUKNHLg52hT7KuupTS5edYkHRAjFwF7teStbsn0n0ZmT7AMcJUe7ApmwZzSSg 4qEQGPfhW7Y1es3Qng6BfTE2okFeHwmcZlN7PbBTW4ucMd1ElwGkvEuRX1ZWL01/hOo0 wBPTBN7qJQ9VZPSOS3q1/hZHe80rSrF7Vxt4YwyCFyWmrJaiQa5ZpNBSpAATmyNAFyNi XWQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684125596; x=1686717596; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rqD9lCkTIuxXh8EyE/Au4wyqwPHCiGeE6RebyCPkCgE=; b=N8zZLJ8aR4PoAph8diTbLxE9MX7lXCtmdkZgeAQFcqlDU3i0l4IJVjC3juPPT2Pzt1 5Yl0hZP45yMMjwrJedC0mz6F3qW97wc9XRMWvNB37IxWsuTm6Xcewko+S82M0gQ20HcK VI1MVGd8GBT9qMrPxXQGuI7+/RLag+YXCsx3whJOdl8kHXhFcF4dymxPEgR5WGp1s4pC q5s9EBgAPQr/NPDA0KvtBw5wk6uQ87/vtFg41zuxbJywEwpjBKD3ACW7SvBsxW3ripfk x1hnvAljfEkB+BIm9PVNJTLr+0HQ6tRWt3iQpYPZSjH/b5Bs3y+LPT+kA7HXjP+ku9fu ioJg== X-Gm-Message-State: AC+VfDyHIbL3VG3o4yGAiHzZcN2PL4QWAtUOa8CzR2BFOOg3nHvKwzuG NOkNKAinKxeVSw91CXHIK6855+aupU0= X-Google-Smtp-Source: ACHHUZ4N4m1IJmVQT/2jXzslZAD14tlkmIqAL3l3klbHG1GWHg4dAKD71ziqWyfgr+ECaKEujxAscQ== X-Received: by 2002:a05:6a00:8c5:b0:647:4dee:62a4 with SMTP id s5-20020a056a0008c500b006474dee62a4mr26740151pfu.34.1684125595666; Sun, 14 May 2023 21:39:55 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id v6-20020a63d546000000b004fbd91d9716sm10483695pgi.15.2023.05.14.21.39.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 May 2023 21:39:55 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261726 Archived-At: On 5/8/2023 9:47 PM, Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Here attached is a draft patch to update eshell defcustoms. The commit > message contains a long [TODO] section outlining all my ideas on how to > change a given portion, but these ideas probably need more input. Thanks, I think most of these make sense. I'm not too sure what to do about the parts you marked with "TODO" though; it'll take some thought for each of them. (For example, I feel like there's a better way to let users customize the keys in em-rebind.el and elsewhere.) How about removing them from the patch, and then we can merge the remainder?