From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50244: 28.0.50; Support project-wide diagnostics reports in flymake.el Date: Mon, 30 Aug 2021 09:00:32 +0200 Message-ID: <174BCB34-6273-40F4-8F58-12BAC76E6702@thornhill.no> References: <87bl5hm5qj.fsf@gmail.com> <8dfca367-baa8-c4ae-8e6b-8ca41d5a63d6@yandex.ru> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15648"; mail-complaints-to="usenet@ciao.gmane.io" To: Dmitry Gutov , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 50244@debbugs.gnu.org, p.stephani2@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 30 09:13:43 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKbUE-0003o8-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Aug 2021 09:13:43 +0200 Original-Received: from localhost ([::1]:42186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKbUC-0005D9-Ch for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Aug 2021 03:13:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKbHy-0002Px-Ip for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 03:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKbHy-0002kF-8G for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 03:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKbHy-0007sX-6Y for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 03:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Aug 2021 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50244 X-GNU-PR-Package: emacs Original-Received: via spool by 50244-submit@debbugs.gnu.org id=B50244.163030684730242 (code B ref 50244); Mon, 30 Aug 2021 07:01:02 +0000 Original-Received: (at 50244) by debbugs.gnu.org; 30 Aug 2021 07:00:47 +0000 Original-Received: from localhost ([127.0.0.1]:57968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKbHf-0007re-0y for submit@debbugs.gnu.org; Mon, 30 Aug 2021 03:00:47 -0400 Original-Received: from out2.migadu.com ([188.165.223.204]:64531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKbHZ-0007rL-Fh for 50244@debbugs.gnu.org; Mon, 30 Aug 2021 03:00:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1630306835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mZowqPTFbKtX7niLurzXBlMVdCDAN9Ir54se571vL8Q=; b=NVlR4OUlOEK/0RYJQ2zI/3mHo7N+Dxp262FVwzXzDpPiIAoT3F9HGP8Ydns7XVxm8OdQx0 RbwUJ4xdgrOibC4ow/GgcSzyi6hkvEe+10sFCuJ9dvmi531PsX0IUzwlxslDXvq7akxad4 2fAKWAE/DpcBpsK0B6kwVhNn+BZK6AdlcN/4UXDULVCZgPavqoLpg+vzN7t2EOsI7JZd28 bTokeiqeg50+1yzZLMhqMOI0Q7dpuMmDug9TGlywEx5uzyhi5NT/JlxE2zdLw8bXJvEJ7x zzJU3KD7ma0CgzXWXX03lxcNaGToYuebvUS1FElt7qGNaG3b4WEJE4yWfkazow== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <8dfca367-baa8-c4ae-8e6b-8ca41d5a63d6@yandex.ru> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213003 Archived-At: On 30 August 2021 01:27:52 CEST, Dmitry Gutov wrote: >On 29=2E08=2E2021 03:53, Jo=C3=A3o T=C3=A1vora wrote: >> * In what new UI parts is the augmented information to be useful? >>=20 >> Currently, I see only one place, the diagnostic listing buffer >> obtained by M-x flymake-show-diagnostics-buffer=2E That buffer is >> usually associated with only one source buffer >> (flymake--diagnostics-buffer-source)=2E Now it should start listing= all >> the diagnostics for buffers or files known to belong to the same >> project, using 'project=2Eel' functionality for that=2E > > From what I know of this feature is usually organized, we have two=20 >possible kinds of sources of errors: > >1=2E Per buffer, which is currently being edited=2E > Yes, and some LSP servers may only deliver this=2E Typically, though, serv= ers send to gravitate towards 2 these days >2=2E For the whole project, where the notion of project is defined by the= =20 >tool which produces the said list of errors=2E With that approach, when= =20 >you fix an error which triggered some cascading errors in other files,=20 >you can see those other errors fixed too=2E > >Is the idea to build a list of "project errors" using sources of type 1?= =20 >That would seem inefficient, though I suppose some people might want=20 >this too=2E > In the case of elm-language-server, with which I use the most along OmniSh= arp and F#, all of them report all diags in all files known to the project = (as defined by LSP) on the first load, then all potential diags across all = files per edit afterwards=2E This case get super chatty very fast, but sinc= e it always flushes everything one can at least rely on what you get=2E The= pr I made works pretty well performance wise in a medium large repo (~70k = loc elm), at least considering it isn't very polished, awaiting this discus= sion=2E >But I thought the original discussion was about errors from sources of=20 >type 2? Then the whole list provided by the source already belongs to=20 >the same project (how the LSP server understands it, if we use the LSP=20 >example)=2E > >Is there a need for further filtering? Not in the case of LSP, no=2E=20 In addition, the structure the error buffer uses would be nice to expose s= o that one can build utility functions like the ones in the pr=2E Theo