From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#34117: 26.1; Incorrect byte-compile warnings Date: Thu, 17 Jan 2019 11:31:16 -0800 (PST) Message-ID: <172346c1-8bd6-4b26-b55f-acc83aede737@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1547753407 4090 195.159.176.226 (17 Jan 2019 19:30:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 17 Jan 2019 19:30:07 +0000 (UTC) To: 34117@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 17 20:30:03 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkDMZ-0000tu-0r for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Jan 2019 20:30:03 +0100 Original-Received: from localhost ([127.0.0.1]:53568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkDOg-0002ga-1o for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Jan 2019 14:32:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkDOV-0002eF-FU for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 14:32:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkDOU-0000Cr-Lf for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 14:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36062) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkDOU-0000CC-Ht for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 14:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gkDOU-0005LX-6h for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 14:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Jan 2019 19:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.154775350020519 (code B ref -1); Thu, 17 Jan 2019 19:32:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Jan 2019 19:31:40 +0000 Original-Received: from localhost ([127.0.0.1]:35343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkDO7-0005Kt-UD for submit@debbugs.gnu.org; Thu, 17 Jan 2019 14:31:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkDO6-0005Kg-BI for submit@debbugs.gnu.org; Thu, 17 Jan 2019 14:31:38 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:49626) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gkDNt-0007aO-W0 for submit@debbugs.gnu.org; Thu, 17 Jan 2019 14:31:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkDNt-0002TN-5s for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 14:31:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkDNp-0007Pu-G8 for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 14:31:23 -0500 Original-Received: from userp2130.oracle.com ([156.151.31.86]:53222) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gkDNn-0007IQ-PX for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 14:31:20 -0500 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0HJJGNM049404 for ; Thu, 17 Jan 2019 19:31:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Mr+vw4qOZhQtt2ellUiXnm7wQ4vShS/mNN531VKOZB4=; b=UhYJRZ/MgJVb2QmePYcSsoVGPCzWt5r2jQX2MChycVN8kcl9n1Wcwl1E4KAjNp089BE1 8gy1IBqFU9cBcst316cPlMTB4d1v/ca/tkg5OlVhUPIzk+2GmisYjb91ba8ytw7zIPm3 wWWYDdOx157ToDXuv6/cpzHYp7kMh6N3MhNU387ecpNFrklyYvZv7eGDoLWVHCwrQOHd SYzC9vo475mpw8j1qZ7QACB2C5bhoUaESx2Y184XnJ4qYiAZ0VgOANKyj5J4oQ0pYmOD HJKPP7PKGV1nar4ox1gGj2cBIyfF2xBCMHgmQNmD6Lk/wvLwT4MWq5rKOeFyU3NOd5QN /A== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2pybkcswnk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 17 Jan 2019 19:31:17 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x0HJVHLm018935 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 17 Jan 2019 19:31:17 GMT Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x0HJVGQU008687 for ; Thu, 17 Jan 2019 19:31:17 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4783.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9139 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901170135 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154529 Archived-At: Byte-compiling a sexp such as this: (make-obsolete-variable 'foo 'bar) raises a warning such as this: Warning: make-obsolete-variable called with 2 arguments, but requires 3-4 That's wrong. It is incorrect that it requires 3 or 4. It requires only 2. The code for `make-obsolete-variable' has this comment, which betrays the probable (misguided) motivation for the warning: "New code should always provide the `when' argument." New code? This comment, and the resulting warning, seem to be targeted at core Emacs developers, not users. "Require" means require. This function does NOT require 3 or 4 args. It is important for backward compatibility that requier only 2 args. It might be desirable for users, as well as core Emacs developers, to use 3 or 4 args, but neither the 3rd nor the 4th should be required (and neither IS required). The warning should be removed - there is nothing to warn about. There are ways to _encourage_ users to add a third arg (WHEN). Warning them that it is _required_ is not appropriate. The byte-compiler should not lie. Same misguided approach to `make-obsolete'. Only 2 args are required. It is inappropriate, misleading, and unnecessary to tell users that 3 are required. In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-30 Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3''