From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#62009: 29.0.60; Emacs crashes on setf symbol-name Date: Fri, 10 Mar 2023 11:57:43 +0000 Message-ID: <16ecbe9ea8d500fa1a07@heytings.org> References: <87o7p5of4n.fsf@daniel-mendler.de> <871qm01s6n.fsf@web.de> <9fcf05e8-506c-6566-e214-2ecf3194b85e@daniel-mendler.de> <83bkl45ul4.fsf@gnu.org> <87v8j9zl3i.fsf@posteo.net> <83a60l13p2.fsf@gnu.org> <16ecbe9ea8ba9d39d058@heytings.org> <16ecbe9ea85b22d008fd@heytings.org> <43460d2c-ba80-0f2f-656c-ef0aca5667b5@daniel-mendler.de> <87fsacx2qf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24291"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , michael_heerdegen@web.de, Daniel Mendler , monnier@iro.umontreal.ca, 62009@debbugs.gnu.org, Eli Zaretskii , Augusto Stoffel To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 10 12:58:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pabOB-00064r-19 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Mar 2023 12:58:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pabNr-00021K-0b; Fri, 10 Mar 2023 06:58:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabNq-0001zc-9S for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 06:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pabNq-00005i-14 for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 06:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pabNp-00059L-Te for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 06:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2023 11:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62009 X-GNU-PR-Package: emacs Original-Received: via spool by 62009-submit@debbugs.gnu.org id=B62009.167844946619763 (code B ref 62009); Fri, 10 Mar 2023 11:58:01 +0000 Original-Received: (at 62009) by debbugs.gnu.org; 10 Mar 2023 11:57:46 +0000 Original-Received: from localhost ([127.0.0.1]:53903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pabNa-00058g-67 for submit@debbugs.gnu.org; Fri, 10 Mar 2023 06:57:46 -0500 Original-Received: from heytings.org ([95.142.160.155]:34062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pabNY-00058Y-L9 for 62009@debbugs.gnu.org; Fri, 10 Mar 2023 06:57:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1678449463; bh=cIIan/0C4PVWB+EtfiDUaK8BwjHHnavUgYXoii8dSpM=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=gbxON/Ql2gcATBPKZgGclvL+y5dVMCibTeopec5SpjpxiZM24RPwuSQiWWdXsyZPm HU6f2QoswDNVO0s7TOAadmU99wCA6xlz+IJtA8wIzcGOrKiZRZgdSZXebIN2jw8/qa +R+Z/f3+nqNvRBvk5wSGaSRJTeuFUcLRT3F3CAKkPlyfXhHm9NbzA448WII5NwYuio uxMWaqXHTyaq5euA+eQBgLE3atk2VlwB+e+pnjfws8AzplS+6/R8QS3+8IBR4E3lDa 4+GvytWh04ZTPb6G6uNEXKRhRV3KFpnli6/rgviPIbKfGcBdla7DVXxgQDtVgGIQs7 WyiKL3EfCMFNw== In-Reply-To: <87fsacx2qf.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257680 Archived-At: > > diff --git a/src/lisp.h b/src/lisp.h > index 1276285e2f2..80bbb047824 100644 > --- a/src/lisp.h > +++ b/src/lisp.h > @@ -1685,6 +1685,8 @@ SREF (Lisp_Object string, ptrdiff_t index) > INLINE void > SSET (Lisp_Object string, ptrdiff_t index, unsigned char new) > { > + if (XSTRING (string)->u.s.size_byte == -2) > + Fsignal (Qsetting_constant, string); > SDATA (string)[index] = new; > } > INLINE ptrdiff_t > That flag is useful only for the first part of the bug: setting the symbol name of a function defined in C. It does not prevent changing symbol names in general, e.g. (aset (symbol-name 'find-file) 1 ?o).