From: James Felix Black <jfb@homonculus.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 38675@debbugs.gnu.org
Subject: bug#38675: 27.0.50; define-obsolete-face-alias definition does not match documentation
Date: Sat, 21 Dec 2019 17:47:45 -0500 [thread overview]
Message-ID: <16FD07C7-AEB6-4E43-8707-64F6B2FD8635@homonculus.net> (raw)
In-Reply-To: <83sgleyq5f.fsf@gnu.org>
I’m easy either way. Do the usage and docs match the other “define-obsolete-“ macros?
> On Dec 21, 2019, at 04:38, Eli Zaretskii <eliz@gnu.org> wrote:
>
>
>>
>> From: James Felix Black <jfb@homonculus.net>
>> Date: Thu, 19 Dec 2019 12:49:01 -0500
>>
>> This was discovered in `haskell-mode` [1]. The documentation of define-obsolete-face-alias claims that `when` is optional, but the macro definition does not follow the docs. This patch fixes the problem.
>
> I'm not sure this isn't a confusion caused by ambiguous wording of the
> doc string. I think by "if provided" it means that WHEN can be nil.
> The ELisp manual, btw, doesn't have this problem.
>
> Would it be okay to modify the doc string instead to say WHEN is
> required, but can be nil?
>
> Thanks.
next prev parent reply other threads:[~2019-12-21 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 17:49 bug#38675: 27.0.50; define-obsolete-face-alias definition does not match documentation James Felix Black
2019-12-21 9:38 ` Eli Zaretskii
2019-12-21 17:54 ` Glenn Morris
2019-12-21 22:47 ` James Felix Black [this message]
2019-12-28 9:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16FD07C7-AEB6-4E43-8707-64F6B2FD8635@homonculus.net \
--to=jfb@homonculus.net \
--cc=38675@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).