From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Kirill A. Korinsky" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS Date: Tue, 14 Sep 2021 02:05:37 +0200 Message-ID: <16F124DC-AFCD-41D6-B039-CB1BD715FBFE@korins.ky> References: <1F1BB95A-CCD9-4602-9CBB-0539D311B438@korins.ky> <63382A54-A99A-45DD-9527-F1DF742ABEEB@korins.ky> <43E37DDD-8314-4A12-8111-A7C48F625BD7@korins.ky> Reply-To: "Kirill A. Korinsky" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: multipart/signed; boundary="Apple-Mail=_74E0E698-071D-4C4F-BF6B-FF3238F3AFE3"; protocol="application/pgp-signature"; micalg=pgp-sha512 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20087"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50534@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 14 02:06:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPvxl-0004ze-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 02:06:13 +0200 Original-Received: from localhost ([::1]:44242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPvxj-0007ys-AU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 20:06:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPvxb-0007yU-2h for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 20:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPvxa-0001fq-RL for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 20:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPvxa-0005pQ-I0 for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 20:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Kirill A. Korinsky" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2021 00:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50534 X-GNU-PR-Package: emacs Original-Received: via spool by 50534-submit@debbugs.gnu.org id=B50534.163157795422390 (code B ref 50534); Tue, 14 Sep 2021 00:06:02 +0000 Original-Received: (at 50534) by debbugs.gnu.org; 14 Sep 2021 00:05:54 +0000 Original-Received: from localhost ([127.0.0.1]:47080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPvxR-0005p3-BM for submit@debbugs.gnu.org; Mon, 13 Sep 2021 20:05:53 -0400 Original-Received: from sender4-op-o12.zoho.com ([136.143.188.12]:17216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPvxP-0005or-20 for 50534@debbugs.gnu.org; Mon, 13 Sep 2021 20:05:52 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1631577946; cv=none; d=zohomail.com; s=zohoarc; b=SZrXxKxJuus1yqyKzZNSIuW8Bx7Zd4Yz8sFqF3aMH5YRGJZVRKWdO1q6KAdrnPL4MO7UPiAUwvU7yFTczmNUZ2hT2+WurI2Whlra+IHuI4kD4l2khHFXKdTpIsiUQy7cX+Z6mIOw6mwnTVUXm38qk7r51hjS8/jA8UJ9ZWwqa4Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631577946; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=wybj95iwJw/xj/a1oNq9e58E7Ilt9nIoDiLNGmIVX2M=; b=HmaBPVenq0qLD256kZuvUSL4AA2kWnw2KYlzMw2ZpQ69FGrzEigX3SlCLghl+Htw/xqQjWkSe0nortyw+f1rWd1090xL1yQPrEYqENzpVfWGC6erU/CQplWBBtuA44wSLFcHXiza5wWzbCx3jkI3S0BhrhRN2PNW6R+XzEpJ2oY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=korins.ky; spf=pass smtp.mailfrom=kirill@korins.ky; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631577946; s=april2018zoho; d=korins.ky; i=kirill@korins.ky; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Message-Id:References:To; bh=wybj95iwJw/xj/a1oNq9e58E7Ilt9nIoDiLNGmIVX2M=; b=ZRMYKBydl/C68M9xR/GxJHnR5acBrRtPlZ13ywFkZDV/Z1HvTbhMS6ns9s0mED85 LFaQRSFP05C9iRzD//xF5MomL52pWVxbMrjGXAfJZk8Zjbc4zJ7c9UX0Fb3T2zBvxHZ yZtFCgmSYQcSyD1fEuPcI24WMPbRsI7L1I+Et048= Original-Received: from smtpclient.apple (sa31.catap.net [90.187.54.213]) by mx.zohomail.com with SMTPS id 1631577941338791.9235982296024; Mon, 13 Sep 2021 17:05:41 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Zoho-Virus-Status: 1 X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214274 Archived-At: --Apple-Mail=_74E0E698-071D-4C4F-BF6B-FF3238F3AFE3 Content-Type: multipart/alternative; boundary="Apple-Mail=_9B711EA2-D40B-446E-954D-99FE11C684B0" --Apple-Mail=_9B711EA2-D40B-446E-954D-99FE11C684B0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii and it works! Thanks! -- wbr, Kirill > On 14. Sep 2021, at 01:25, Alan Third wrote: >=20 > On Tue, Sep 14, 2021 at 12:21:27AM +0200, Kirill A. Korinsky wrote: >> Maybe it can be for some use. >>=20 >> I've attached the minimal patch which fixed issue for me. >>=20 >> This patch reverted some of your changes. >>=20 >> Because when I move to full screen =3D> toolbar is dissapear, I feel = that the root cause is replacing layoutSublayersOfLayer to layout. >>=20 >> Anyway, I don't know quartz and I can't minimize it future. >=20 > It has to be a timing issue. None of the code you're changing touches > the toolbar or its visibility, directly or indirectly, so any change > there can only be altering when various pieces of code are called. >=20 > Changing to and from fullscreen explicitly resets the toolbar's > visibility. >=20 > I think what we probably want to do is default the toolbar to > non-visible when it's created (at the moment it's using the default, > which I suspect is visible), and then rely on the fact that > update_frame_tool_bar is always called when it should be visible to > turn it back on. >=20 > Patch attached. > -- > Alan Third > --Apple-Mail=_9B711EA2-D40B-446E-954D-99FE11C684B0 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii and = it works!

Thanks!

-- 
wbr, Kirill

On 14. Sep 2021, at 01:25, Alan Third <alan@idiocy.org> = wrote:

On Tue, Sep 14, 2021 at 12:21:27AM +0200, Kirill A. Korinsky = wrote:
Maybe it can = be for some use.

I've attached the minimal = patch which fixed issue for me.

This patch = reverted some of your changes.

Because when = I move to full screen =3D> toolbar is dissapear, I feel that the root = cause is replacing layoutSublayersOfLayer to layout.

Anyway, I don't know quartz and I can't minimize it = future.

It has to be a timing = issue. None of the code you're changing touches
the = toolbar or its visibility, directly or indirectly, so any change
there can only be altering when various pieces of code are = called.

Changing to and from fullscreen = explicitly resets the toolbar's
visibility.

I think what we probably want to do is default = the toolbar to
non-visible when it's created (at the = moment it's using the default,
which I suspect is = visible), and then rely on the fact that
update_frame_tool_bar is always called when it should be = visible to
turn it back on.

Patch attached.
--
Alan Third
<v4-0001-Fix-incorrectl= y-appearing-toolbar-on-NS-bug-50534.patch>

= --Apple-Mail=_9B711EA2-D40B-446E-954D-99FE11C684B0-- --Apple-Mail=_74E0E698-071D-4C4F-BF6B-FF3238F3AFE3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3/KLNtcfWfLw7JxqmNjZhndZIm4FAmE/51EACgkQmNjZhndZ Im7I7hAAhdZCvBAcm7vJh19/iZtGz3zLBKOgHQH+L7nFBSdRmPQtLNCwfF787wux PfXdlbmnWwgJsVaulESuFj0JifBTY4SYlRvNCGbgEd28dh2prbucDsaVv6E7XDOF OSZQnJRh3YmvHrMXMSbZwUvj20NLKtjHZ3iDIT+CAF5miv7XLH/Vs1DwYJLaAPyJ erGKrcuUVnxh6ez10bi6EAXEJYBYgax9EUsFB4PWHz7TdeFnw1fnyVymT0xQ2g1w bnGaAF5D/Zh/AWpKVGpconREJk84Sov5JF/mHDomoH99qmREP3kA75LLbkKYVudO xNdf7IR4j6wBib6hgO3Yvhflmn8BNm0CCl9mrSsXAInM4IHYrB7aGZTJ3RqvgrSy 7xdT+uxWwS6YkO0WJtiwARgf3n7dEDp0a1B7qvlpvpuX+AXxgmxg4GpqlphHQfd/ EpoAGaQfbkjWze5w/zSiDMLHWTVDVLhiESVWTYBAfXpkSBNRj+8O9m/UmW7pmBJu bYBlS1OPf/cVCkM8h7QTJ72Evjv92v/v4/etElxIbFUnM4OczOp1ILioB6fYMubv ucJ+NcX48uFrp4bjI9mYK06rFIoB97Mt9PDBvR40npJ1AnhMvV7CTgHX5f7Dv4dE AoXjgubpVgjBtC/KOFqCtroFf3PAaTwVXAFSqRR0ctOAjyXo9Zo= =HRoc -----END PGP SIGNATURE----- --Apple-Mail=_74E0E698-071D-4C4F-BF6B-FF3238F3AFE3--