bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS

["Kirill A. Korinsky" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1266 bytes --]

and it works!

Thanks!

--
wbr, Kirill

> On 14. Sep 2021, at 01:25, Alan Third <alan@idiocy.org> wrote:
> 
> On Tue, Sep 14, 2021 at 12:21:27AM +0200, Kirill A. Korinsky wrote:
>> Maybe it can be for some use.
>> 
>> I've attached the minimal patch which fixed issue for me.
>> 
>> This patch reverted some of your changes.
>> 
>> Because when I move to full screen => toolbar is dissapear, I feel that the root cause is replacing layoutSublayersOfLayer to layout.
>> 
>> Anyway, I don't know quartz and I can't minimize it future.
> 
> It has to be a timing issue. None of the code you're changing touches
> the toolbar or its visibility, directly or indirectly, so any change
> there can only be altering when various pieces of code are called.
> 
> Changing to and from fullscreen explicitly resets the toolbar's
> visibility.
> 
> I think what we probably want to do is default the toolbar to
> non-visible when it's created (at the moment it's using the default,
> which I suspect is visible), and then rely on the fact that
> update_frame_tool_bar is always called when it should be visible to
> turn it back on.
> 
> Patch attached.
> --
> Alan Third
> <v4-0001-Fix-incorrectly-appearing-toolbar-on-NS-bug-50534.patch>


[-- Attachment #1.2: Type: text/html, Size: 2596 bytes --]

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]