From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59471: [PATCH] sh-mode: Run treesit-ready-p only when sh-shell is 'bash Date: Tue, 22 Nov 2022 17:39:08 -0800 Message-ID: <16C1E196-AD5B-4358-BCFD-BF5995EC21D0@gmail.com> References: <87bkozpukg.fsf@posteo.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35596"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59471-done@debbugs.gnu.org To: leungbk@posteo.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 02:40:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxekR-000970-DG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 02:40:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxekB-0005te-7u; Tue, 22 Nov 2022 20:40:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxekA-0005tK-14 for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 20:40:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxek6-0005g0-Ft for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 20:40:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxek6-0005eq-4h for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 20:40:02 -0500 In-Reply-To: <87bkozpukg.fsf@posteo.net> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 01:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 59471@debbugs.gnu.org, casouri@gmail.com, leungbk@posteo.net Original-Received: via spool by 59471-done@debbugs.gnu.org id=D59471.166916756321691 (code D ref 59471); Wed, 23 Nov 2022 01:40:01 +0000 Original-Received: (at 59471-done) by debbugs.gnu.org; 23 Nov 2022 01:39:23 +0000 Original-Received: from localhost ([127.0.0.1]:52965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxejS-0005dn-MB for submit@debbugs.gnu.org; Tue, 22 Nov 2022 20:39:22 -0500 Original-Received: from mail-pl1-f170.google.com ([209.85.214.170]:37777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxejN-0005dW-E1 for 59471-done@debbugs.gnu.org; Tue, 22 Nov 2022 20:39:20 -0500 Original-Received: by mail-pl1-f170.google.com with SMTP id p12so15335501plq.4 for <59471-done@debbugs.gnu.org>; Tue, 22 Nov 2022 17:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=c1emr8PoFW4rSKxw1h077mYF4q0mtM1M4AvTdFYRjto=; b=bthChdLW932HDdLaZyrOTLivBGS0QkU8/1dCGhfGJQvzdotaUIAs3EUouSEcTudv9A oyRew7QkZy+/nrqbamfMFGZun5rRfq5pl99KFREko/k5cGogv7M6Xmw31kr8WTvFLMkl VlNyByOqeU6VkBMaYaOZtIjOsE/jJcolmJtaG20om7wFgZM1vnXyFMZiP/Jg+IHNa7RM ugyWIPs/sydQ4zq8P2Q8H74EY9gc6uICjpQqeq7yVIVQ8b10RByf3llIeaNVeyrxI3Zs Od6Ub1JH9EbQESqblEREwHc9RMmsc/3rhbh+ecGwqthh8vE/EJKJDHhPun7bKOtz23Ri Cmcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c1emr8PoFW4rSKxw1h077mYF4q0mtM1M4AvTdFYRjto=; b=L7kWdZhtFaATvnQkcYg3cPhI8WPcQaSTxjHM9X6/v6vi23PS10gDv6q54Jgyfoe91G WlFRfK6JSLmfzo1v/vgVYfBuqAYh6jUih7n3jF0PQny4NbGqCoMPBwHONFxtDZWK05Vb GPG7ZmESs/05+9EpEmQ9MRB3CkJMalZDYuB5VcmzJI6ucKW2x3tGT0YMuWojSQmGkM3L 60chFUy0tlLAD9ntmF8G7bKZPPzKDPwunSnCClKpoEAx1ACzt1b2nTEyBngSUupjex6e kECtDY/rGCOYrG2UZpBIp3pzuWYcgHBHJ7pC1judKnvx6Riof4zgrJ9zDWpEIY/w2WnR duUQ== X-Gm-Message-State: ANoB5pmaOcrLoXAzH8QZ0RLUoL1faC0soR60U2s2z6yDmcxctaUSJHmV jsRTQ+A5VV8T3M4JBiM/06w= X-Google-Smtp-Source: AA0mqf4rDtsjrRKh1qT6khDIDaeuDVKJ73NwU59lNf7cyqk1kGhivKpEsbBUL5E+tlkRBXCKKvBRUg== X-Received: by 2002:a17:902:b908:b0:189:1ef4:237b with SMTP id bf8-20020a170902b90800b001891ef4237bmr7059266plb.20.1669167551311; Tue, 22 Nov 2022 17:39:11 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x3-20020aa79403000000b0056d2317455bsm11324010pfo.7.2022.11.22.17.39.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2022 17:39:10 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248698 Archived-At: Brian Leung writes: > Tags: patch > > This patch guards the treesit-ready-p check to run only when sh-shell is > 'bash, in order to prevent an annoying warning when viewing (say) sh or > zsh files. But maybe we also want to allow treesitter when sh-shell is > 'sh? Oh, thanks! Though I did it a bit differently, by separating tree-sitter-based mode into a independent major mode (sh-ts-mode), which is in line with other tree-sitter-based modes (python-ts-mode, js-ts-mode, etc). How to make bash-ts-mode fallback to sh-mode when it encounters a shell script other than bash is still in discussion. Yuan