From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Koen van Greevenbroek Newsgroups: gmane.emacs.bugs Subject: bug#52260: Fix compilation error in feature/pgtk branch Date: Fri, 03 Dec 2021 09:20:53 +0000 Message-ID: <1656047e6c87e052a7bbc7010410de4d7b500246.camel@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28352"; mail-complaints-to="usenet@ciao.gmane.io" To: 52260@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 03 15:23:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mt9T1-00075h-Dn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Dec 2021 15:23:15 +0100 Original-Received: from localhost ([::1]:47080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mt9T0-0007lK-HW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Dec 2021 09:23:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt9So-0007gU-VD for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 09:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mt9So-000423-MF for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 09:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mt9So-0004SL-IR for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 09:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Koen van Greevenbroek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Dec 2021 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52260 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163854133017047 (code B ref -1); Fri, 03 Dec 2021 14:23:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Dec 2021 14:22:10 +0000 Original-Received: from localhost ([127.0.0.1]:50331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt9Rx-0004Qr-2i for submit@debbugs.gnu.org; Fri, 03 Dec 2021 09:22:10 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:51544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt4kf-00068w-On for submit@debbugs.gnu.org; Fri, 03 Dec 2021 04:21:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt4kf-0006Mj-GV for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 04:21:09 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:59087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt4ka-0000i8-A3 for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 04:21:09 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 94542240104 for ; Fri, 3 Dec 2021 10:20:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1638523259; bh=BumGPM4/rZGL6j2WoyH1HtKp2OouYvY/QPD3D+vkMaY=; h=Subject:From:To:Date:From; b=io6SHzE/UIyFnN579ge783KP+asWcbhmGNEGLzx+04Rf1mQ/iqxD4TgGxlK4Hrbfq QZVxyb8PFRfKz14WgKg9oS5UY3ZJqdauE86xj2ofX15uwpoQEaZbjo2C2jmBZKeydf ZKEkxdIZuSXDb00WLLV9C10fQWqCu2YRdQBsoN88jvEy0o7Z5iPij/YbIy74RbihDK dSGjaX+6N3RdWf6Z4LN5zF8yNomsBYN7oGb6am+qWK9/ApW72nSocUqCuRrN7+JXrv GW4uRQSTs+OET9d4ltXvaOnE/4/t7DNyFatu1c4ffPlHR2gyH0KGyYeIvj1PVNsXBj TRxOyY7Af9ShQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4J56kf25Kfz9rxG for ; Fri, 3 Dec 2021 10:20:58 +0100 (CET) Received-SPF: pass client-ip=185.67.36.66; envelope-from=koen_devel@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 03 Dec 2021 09:22:07 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221382 Archived-At: Hi, I was just trying to compile the latest version of the pgtk branch when I noticed that commit 901938109f introduced a regression: two empty switch cases will result in a compilation error. My suggested fix is the following: Fix compilation error due to empty switch cases modified src/pgtkterm.c @@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f) case FULLSCREEN_WIDTH: case FULLSCREEN_HEIGHT: + ; /* Not supported by gtk. Ignore them. */ } This fixes the compilation error for me; I don't know if there is a more idiomatic way of solving this. Kind regards, Koen van Greevenbroek