bug#52260: Fix compilation error in feature/pgtk branch

bug#52260: Fix compilation error in feature/pgtk branch

[Koen van Greevenbroek]

Hi,

I was just trying to compile the latest version of the pgtk branch when
I noticed that commit 901938109f introduced a regression: two empty
switch cases will result in a compilation error. My suggested fix is
the following:

Fix compilation error due to empty switch cases

modified   src/pgtkterm.c
@@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f)
 
     case FULLSCREEN_WIDTH:
     case FULLSCREEN_HEIGHT:
+	;
       /* Not supported by gtk. Ignore them. */
     }


This fixes the compilation error for me; I don't know if there is a
more idiomatic way of solving this.

Kind regards,

Koen van Greevenbroek

bug#52260: Fix compilation error in feature/pgtk branch

[Lars Ingebrigtsen]

Koen van Greevenbroek <koen_devel@posteo.net> writes:

> I was just trying to compile the latest version of the pgtk branch when
> I noticed that commit 901938109f introduced a regression: two empty
> switch cases will result in a compilation error. My suggested fix is
> the following:
>
> Fix compilation error due to empty switch cases
>
> modified   src/pgtkterm.c
> @@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f)
>
>      case FULLSCREEN_WIDTH:
>      case FULLSCREEN_HEIGHT:
> +	;
>        /* Not supported by gtk. Ignore them. */
>      }
>
> This fixes the compilation error for me; I don't know if there is a
> more idiomatic way of solving this.

I think adding a "break;" is the normal way to do it, so I've now done
this on the pgtk branch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no