From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.bugs Subject: Re: in dired hit v on a .zip archive Date: Fri, 9 Apr 2004 16:01:51 -0600 Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Message-ID: <16503.7503.197216.954177@ihs.com> References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1081548494 11927 80.91.224.253 (9 Apr 2004 22:08:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 9 Apr 2004 22:08:14 +0000 (UTC) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 10 00:08:04 2004 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BC4AN-0003k4-00 for ; Sat, 10 Apr 2004 00:08:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BC4AE-0007lf-2l for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Apr 2004 18:07:54 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BC49t-0007Qc-6N for bug-gnu-emacs@gnu.org; Fri, 09 Apr 2004 18:07:33 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BC49Z-00074U-7F for bug-gnu-emacs@gnu.org; Fri, 09 Apr 2004 18:07:22 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BC49Y-00073O-FS for bug-gnu-emacs@gnu.org; Fri, 09 Apr 2004 18:07:12 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.24) id 1BC49Y-0000vI-9D for gnu-emacs-bug@gnu.org; Fri, 09 Apr 2004 18:07:12 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BC46C-0005vo-Ua for gnu-emacs-bug@gnu.org; Fri, 09 Apr 2004 18:04:17 -0400 Original-Received: from [170.207.70.222] (helo=mail1.ihs.com) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BC45t-0005jk-Et for gnu-emacs-bug@gnu.org; Fri, 09 Apr 2004 18:03:25 -0400 Original-Received: from briard.ihs.com (esd80.ihs.com [170.207.51.80]) by mail1.ihs.com (8.12.10/8.12.10) with SMTP id i39M1c1o009161 for ; Fri, 9 Apr 2004 16:01:38 -0600 (MDT) Original-Path: 170.207.51.80!not-for-mail Original-Lines: 43 X-Orig-NNTP-Posting-Host: 170.207.51.80 X-Orig-X-Trace: news.uni-berlin.de 1081527327 93059773 I 170.207.51.80 ([82742]) User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:0.9.4.1) Gecko/20020406 Netscape6/6.2.2 X-Accept-Language: en-us X-Spamscanner: mailbox5.ucsd.edu (v1.4 Mar 10 2004 15:18:19, 2.2/5.0 2.63) X-MailScanner: PASSED (v1.2.8 49342 i39GFSxl078884 mailbox5.ucsd.edu) Original-To: gnu-emacs-bug@gnu.org Original-Newsgroups: gnu.emacs.bug X-IHS-MailScanner: Found to be clean X-IHS-MailScanner-SpamCheck: X-IHS-MailScanner-Envelope-Sender: kevinr@ihs.com X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.bugs:7549 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:7549 Dan Jacobson wrote: > In dired hit v on a .zip archive. > Now both view mode and zip-archive mode are in effect. > I say only zip-archive mode should be now in effect, just as if we hit RET. I say Emacs is behaving correctly and as documented: | v runs the command dired-view-file | which is an interactive compiled Lisp function in `dired'. | (dired-view-file) | | In dired, examine a file in view mode, returning to dired when done. > Just as when we hit v on a subdirectory, are we put into view mode? > No, we are put into dired mode. But we _should_ be put in View mode. Here's a patch: *** emacs-21.3/lisp/dired.el.orig Fri Feb 7 04:48:13 2003 --- emacs-21.3/lisp/dired.el Fri Apr 9 09:53:54 2004 *************** *** 1396,1402 **** (if (file-directory-p (dired-get-filename)) (or (and (cdr dired-subdir-alist) (dired-goto-subdir (dired-get-filename))) ! (dired (dired-get-filename))) (view-file (dired-get-filename)))) (defun dired-find-file-other-window () --- 1396,1403 ---- (if (file-directory-p (dired-get-filename)) (or (and (cdr dired-subdir-alist) (dired-goto-subdir (dired-get-filename))) ! (let ((find-file-run-dired t)) ! (view-file (dired-get-filename)))) (view-file (dired-get-filename)))) (defun dired-find-file-other-window () -- Kevin Rodgers