unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kevin Rodgers <ihs_4664@yahoo.com>
Subject: Re: in dired hit v on a .zip archive
Date: Fri, 9 Apr 2004 16:01:51 -0600	[thread overview]
Message-ID: <16503.7503.197216.954177@ihs.com> (raw)
In-Reply-To: mailman.427.1081466848.23317.bug-gnu-emacs@gnu.org

Dan Jacobson wrote:
 > In dired hit v on a .zip archive.
 > Now both view mode and zip-archive mode are in effect.
 > I say only zip-archive mode should be now in effect, just as if we hit RET.

I say Emacs is behaving correctly and as documented:

| v runs the command dired-view-file
|    which is an interactive compiled Lisp function in `dired'.
| (dired-view-file)
|
| In dired, examine a file in view mode, returning to dired when done.

 > Just as when we hit v on a subdirectory, are we put into view mode?
 > No, we are put into dired mode.

But we _should_ be put in View mode.  Here's a patch:

*** emacs-21.3/lisp/dired.el.orig	Fri Feb  7 04:48:13 2003
--- emacs-21.3/lisp/dired.el	Fri Apr  9 09:53:54 2004
***************
*** 1396,1402 ****
     (if (file-directory-p (dired-get-filename))
         (or (and (cdr dired-subdir-alist)
   	       (dired-goto-subdir (dired-get-filename)))
! 	  (dired (dired-get-filename)))
       (view-file (dired-get-filename))))

   (defun dired-find-file-other-window ()
--- 1396,1403 ----
     (if (file-directory-p (dired-get-filename))
         (or (and (cdr dired-subdir-alist)
   	       (dired-goto-subdir (dired-get-filename)))
!           (let ((find-file-run-dired t))
!             (view-file (dired-get-filename))))
       (view-file (dired-get-filename))))

   (defun dired-find-file-other-window ()


-- 
Kevin Rodgers

       reply	other threads:[~2004-04-09 22:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.427.1081466848.23317.bug-gnu-emacs@gnu.org>
2004-04-09 22:01 ` Kevin Rodgers [this message]
2004-04-12 19:54   ` in dired hit v on a .zip archive Dan Jacobson
2004-04-13 23:02     ` Kevin Rodgers
2004-04-08 21:54 Dan Jacobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16503.7503.197216.954177@ihs.com \
    --to=ihs_4664@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).