From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#26243: 25.1; `dired-pop-to-buffer' warning Date: Mon, 29 Jul 2019 17:53:52 -0700 (PDT) Message-ID: <1628bf91-2d28-486d-85e5-63ac32c1ede4@default> References: <1355208c-862e-4c1e-8218-a2efdf66142c@default> <87y30lm4l0.fsf@mouse.gnus.org> <87sgqompjl.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="269293"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , 26243@debbugs.gnu.org To: Juri Linkov , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 30 02:55:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsGQK-0017rc-L9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jul 2019 02:55:28 +0200 Original-Received: from localhost ([::1]:57302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsGQJ-0004OR-EU for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jul 2019 20:55:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34111) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsGPw-0004Al-2V for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 20:55:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsGPv-0002hg-3s for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 20:55:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40541) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hsGPu-0002hZ-PT for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 20:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hsGPu-0001fZ-Ls for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 20:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jul 2019 00:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 26243-submit@debbugs.gnu.org id=B26243.15644480456335 (code B ref 26243); Tue, 30 Jul 2019 00:55:02 +0000 Original-Received: (at 26243) by debbugs.gnu.org; 30 Jul 2019 00:54:05 +0000 Original-Received: from localhost ([127.0.0.1]:49362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsGOy-0001e6-DI for submit@debbugs.gnu.org; Mon, 29 Jul 2019 20:54:05 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:51730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsGOw-0001dd-QL for 26243@debbugs.gnu.org; Mon, 29 Jul 2019 20:54:03 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6U0rZVN004833; Tue, 30 Jul 2019 00:53:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=k1STAJpt6R/V5O6DKzbDIB8hpX7ZDuHgfn34DsrqnmY=; b=crHlQuccBLTl4eWdopREoTZe63Xyz6fTyNLfwj9ebJezkM5zThPJGKONXTLe/MCz4KnT 6rp42o36tvMsB59Crrt+oyW72pKDR4sEun4P+y6xJsPH/yxb5vk28E9TuZgNvinTJVI5 PlGVzUKX5+3PNxHUiKOnopOOQ2yu69Be/z2NCYJt0mGH3WqXN5lqMt6ZvTOyn7ZO8lLc dPG/TDngg6o7b3NiRcaZgJ6dBYmE4/RRikTLwy80/seLP3rhHV+jQLwz5NkGuqq7x0S+ gKkxDYsM4cvIBcQP2knLbZoT9vg+RJGSD4zpWZJoP86FoDemhRK7Ak0OPuFmM1JzxT2T pw== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2u0f8qttxr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jul 2019 00:53:56 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6U0qxNk029965; Tue, 30 Jul 2019 00:53:56 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2u0bqtsvn8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jul 2019 00:53:56 +0000 Original-Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x6U0rrTJ003392; Tue, 30 Jul 2019 00:53:54 GMT In-Reply-To: <87sgqompjl.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9333 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907300006 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9333 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907300007 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164085 Archived-At: > Yes, either 'pop-to-buffer' or 'dired-mark-pop-up'. If 'dired-mark- > pop-up' > doesn't suit the needs due to its narrow applicability, then a more > general > 'pop-to-buffer' should be used. 'dired-pop-to-buffer' was an ugly > wrapper > around 'pop-to-buffer' with some additions that now should be specified > as ACTION args of 'display-buffer' (an example is in 'dired-mark-pop- > up'). > I don't understand why Drew still uses 'dired-pop-to-buffer'. I use `dired-pop-to-buffer' in more than one place in my code (Dired+). (I use a different definition of it, but that's not really important here. I also use a different definition of `dired-mark-pop-up'.) `dired-pop-to-buffer' shouldn't have been declared "obsolete" in my opinion. But in any case, surely `dired-mark-pop-up' can't be used to do anything like what it does. (And no, `pop-to-buffer' isn't an adequate replacement for it either.) > some additions that now should be specified > as ACTION args of 'display-buffer' (an example > is in 'dired-mark-pop-up'). FWIW, we apparently disagree about whether using `display-buffer' ACTION args is the way to do things. We likely have different ideas about what is elegant and what is ugly. ;-) When a doc string resorts to telling users things like this, I'd say we're already veering off the elegant road: "use the Customization interface to add a new rule to `display-buffer-alist' where condition regexp is \"^ \\*Marked Files\\*$\", action argument symbol is `window-height' and its value is nil."