unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: 48261@debbugs.gnu.org, Philipp <p.stephani2@gmail.com>
Subject: bug#48261: 28.0.50; Optimize `eql' to `eq' for fixnums
Date: Fri, 7 May 2021 11:23:40 +0200	[thread overview]
Message-ID: <1611E274-F759-4BBE-B136-FB6CDFD557B5@acm.org> (raw)
In-Reply-To: <wvr4y2cr3hkl.fsf@gmail.com>

Good!

+  (and (fixnump o) (<= -536870912 o 536870911)))

Maybe write (<= (- (ash 1 29)) o (1- (ash 1 29))) instead.

+                            (cl-every

Are you sure this is a good idea? See comment in the beginning of bytecomp.el.
Maybe just hold your nose and keep the existing (memq nil (mapcar ...)) hack; the list is usually short.

(We really should have fast, readable, always-available standard functions or macros for 'some' and 'every' on lists.)






  reply	other threads:[~2021-05-07  9:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 17:20 bug#48261: 28.0.50; Optimize `eql' to `eq' for fixnums Philipp Stephani
2021-05-07  9:23 ` Mattias Engdegård [this message]
2021-05-07 15:24   ` bug#48261: [External] : " Drew Adams
2021-05-08  9:17   ` Philipp
2021-05-08 13:26     ` Mattias Engdegård
2021-05-16 12:48       ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1611E274-F759-4BBE-B136-FB6CDFD557B5@acm.org \
    --to=mattiase@acm.org \
    --cc=48261@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).