* bug#18204: 24.4.50; `ediff-file-compressed-p'
@ 2014-08-05 21:49 Drew Adams
2016-04-30 0:38 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2014-08-05 21:49 UTC (permalink / raw)
To: 18204
Could be improved from this:
(defun ediff-file-compressed-p (file)
(condition-case nil
(require 'jka-compr)
(error))
(if (featurep 'jka-compr)
(string-match (jka-compr-build-file-regexp) file)))
to this:
(defun ediff-file-compressed-p (file)
(and (require 'jka-compr nil t)
(string-match-p (jka-compr-build-file-regexp) file)))
Or just remove it altogether - it is used only once.
(Or provide it as a general function, outside `ediff-util'.)
In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --prefix=/c/Devel/emacs/snapshot/trunk
--enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
-Ic:/Devel/emacs/include''
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#18204: 24.4.50; `ediff-file-compressed-p'
2014-08-05 21:49 bug#18204: 24.4.50; `ediff-file-compressed-p' Drew Adams
@ 2016-04-30 0:38 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2016-04-30 0:38 UTC (permalink / raw)
To: Drew Adams; +Cc: 18204
Drew Adams <drew.adams@oracle.com> writes:
> Could be improved from this:
>
> (defun ediff-file-compressed-p (file)
> (condition-case nil
> (require 'jka-compr)
> (error))
> (if (featurep 'jka-compr)
> (string-match (jka-compr-build-file-regexp) file)))
>
> to this:
>
> (defun ediff-file-compressed-p (file)
> (and (require 'jka-compr nil t)
> (string-match-p (jka-compr-build-file-regexp) file)))
Probably written that way for backwards compatibility.
I've now simplified it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-30 0:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-05 21:49 bug#18204: 24.4.50; `ediff-file-compressed-p' Drew Adams
2016-04-30 0:38 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).