From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#25581: 25.1; Incorrect statement in (elisp) `Hooks' Date: Tue, 31 Jan 2017 08:02:31 -0800 (PST) Message-ID: <1578ae0e-be68-47b0-a834-69da76fed9cd@default> References: <8e81acfe-ecaa-4fac-9484-24541b232ba1@default> <87k29cq68h.fsf@users.sourceforge.net> <4218ccf3-da3c-43e3-9901-183e4ec81f71@default> <87efzjrhi7.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1485878895 26123 195.159.176.226 (31 Jan 2017 16:08:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 31 Jan 2017 16:08:15 +0000 (UTC) Cc: 25581@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 31 17:08:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYayV-0006Up-SY for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Jan 2017 17:08:07 +0100 Original-Received: from localhost ([::1]:39235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cYayb-0004cp-9H for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Jan 2017 11:08:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cYate-000090-Uy for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2017 11:03:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cYata-0004r4-2c for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2017 11:03:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54197) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cYatZ-0004qy-Uo for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2017 11:03:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cYatZ-0006qK-Ni for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2017 11:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jan 2017 16:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25581-submit@debbugs.gnu.org id=B25581.148587856326279 (code B ref 25581); Tue, 31 Jan 2017 16:03:01 +0000 Original-Received: (at 25581) by debbugs.gnu.org; 31 Jan 2017 16:02:43 +0000 Original-Received: from localhost ([127.0.0.1]:52396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYatH-0006pm-Jt for submit@debbugs.gnu.org; Tue, 31 Jan 2017 11:02:43 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:23254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYatG-0006pX-Aq for 25581@debbugs.gnu.org; Tue, 31 Jan 2017 11:02:42 -0500 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v0VG2ZI1004238 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Jan 2017 16:02:35 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v0VG2Yt2005149 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 31 Jan 2017 16:02:35 GMT Original-Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id v0VG2WGI010387; Tue, 31 Jan 2017 16:02:33 GMT In-Reply-To: <87efzjrhi7.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128831 Archived-At: > IMO the current wording is pretty unambiguous that a variable ending in > "-function" should be a single function and not a list. But if you feel > differently, please suggest an alternate wording. >=20 > > And such code should also _document_ this (exceptional) > > need for its hook to have only a single function. >=20 > From a quick look at M-x apropos-variable RET .*-function$ RET, every > such variable is described as "a function" or "function" which is > clearly not a list of functions. What can mislead is "such a single-function hook", even though it is used just after introducing variables named `*-function'. If the text is changed to repeat that name criterion then I think it is clearer. Something like this: If the name of the variable ends in `-function' (singular) then its value must be a function, not a list of functions. In this case, to modify the variable value just set it (using `setq' etc.) or advise it (using `add-function' etc.). And yes, I was wrong to say that you could in fact use `add-hook' in this case. Sorry for that noise. The changes needed, I think, are (1) clarify that the requirement of the value being a function applies only to `*-function' vars and (2) be clear that there are multiple ways to change the value, including plain old `setq' (as Mark O pointed out).