From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 13177@debbugs.gnu.org
Subject: bug#13177: 24.3.50; doc of `read-char-by-name'
Date: Sat, 15 Dec 2012 15:39:29 -0800 [thread overview]
Message-ID: <156AF208FCA440DDB10CA4CFBF2815AF@us.oracle.com> (raw)
In-Reply-To: <jwvmwxe9a46.fsf-monnier+emacs@gnu.org>
> > The problem for me is that I don't know what the intention (design)
> > was or why. Maybe someone has a good reason to return nil or to
> > return a number that does not correspond to a recognized code point?
>
> It's called "read-char-by-name", so the intention is pretty clear: it
> should return a char.
Great. That's what I would prefer also. And that was exactly what I said in
the original bug report: that's what the other `read*' functions do: return the
thing their names say they read.
So we start with a code bug - make sure it always returns a char. Then we fix
the doc.
However, this function has been around for a while, so there might be some code
that expects it to sometimes return nil or sometimes a non code-point number.
Hopefully, any code expecting nil is only trying to workaround this same bug...
Anyway, FWIW you've got my vote in favor of fixing the code to always return a
char.
next prev parent reply other threads:[~2012-12-15 23:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 4:01 bug#13177: 24.3.50; doc of `read-char-by-name' Drew Adams
2012-12-15 11:09 ` Juri Linkov
2012-12-15 14:54 ` Stefan Monnier
2012-12-15 15:18 ` Juri Linkov
2012-12-15 15:47 ` Stefan Monnier
2012-12-15 16:08 ` Drew Adams
2012-12-15 23:20 ` Stefan Monnier
2012-12-15 23:39 ` Drew Adams [this message]
2012-12-16 9:12 ` Juri Linkov
2012-12-16 10:18 ` Andreas Schwab
2012-12-16 10:49 ` Juri Linkov
2012-12-16 16:34 ` Drew Adams
2012-12-16 16:31 ` Drew Adams
2012-12-21 7:53 ` Chong Yidong
2012-12-21 8:04 ` Drew Adams
2012-12-15 15:52 ` Drew Adams
2012-12-15 16:08 ` Eli Zaretskii
2012-12-15 16:23 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156AF208FCA440DDB10CA4CFBF2815AF@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=13177@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).