From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#36167: [PATCH v2] Replace manually crafted hex regexes with [[:xdigit:]] Date: Mon, 08 Jul 2019 12:34:32 +0300 Message-ID: <1562578472.8519.0@yandex.ru> References: <1560254386.25060.0@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191519"; mail-complaints-to="usenet@blaine.gmane.org" To: 36167@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 08 11:35:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkQ3J-000ni6-Ub for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 11:35:18 +0200 Original-Received: from localhost ([::1]:39792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkQ3I-00039o-TG for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 05:35:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48596) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkQ37-000345-UY for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 05:35:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkQ36-0006VB-4s for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 05:35:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkQ34-0006UG-ED for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 05:35:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hkQ34-0004BO-9P for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 05:35:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <1560254386.25060.0@yandex.ru> Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2019 09:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156257848616051 (code B ref 36167); Mon, 08 Jul 2019 09:35:02 +0000 Original-Received: (at 36167) by debbugs.gnu.org; 8 Jul 2019 09:34:46 +0000 Original-Received: from localhost ([127.0.0.1]:57739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkQ2n-0004Ap-Os for submit@debbugs.gnu.org; Mon, 08 Jul 2019 05:34:45 -0400 Original-Received: from forward105j.mail.yandex.net ([5.45.198.248]:55619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkQ2k-0004AU-8C for 36167@debbugs.gnu.org; Mon, 08 Jul 2019 05:34:44 -0400 Original-Received: from mxback13j.mail.yandex.net (mxback13j.mail.yandex.net [IPv6:2a02:6b8:0:1619::88]) by forward105j.mail.yandex.net (Yandex) with ESMTP id 68EB6B214C7; Mon, 8 Jul 2019 12:34:35 +0300 (MSK) Original-Received: from smtp2o.mail.yandex.net (smtp2o.mail.yandex.net [2a02:6b8:0:1a2d::26]) by mxback13j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id oNBJoUajKA-YZs0YPVL; Mon, 08 Jul 2019 12:34:35 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1562578475; bh=T9a1orEV6EVIcFDbi0XFy2NiQMAFtCveLiUeMVn8/cY=; h=Cc:To:Subject:From:Date:Message-Id; b=INucFYRKy2OFzS1oHMJ8QtU0RFwrCw2qKzNFqWITWuZvXawSpRtHVRCl1qOmExa/h 1PXSJRCB7FnUGjDSYmvjyFydkrLeZPuHqULZQfrln6hYbN8P/okNH0pwQZDUmS6ubF pPsS1DoenVwISvY5N6rF55JlKdT5kKuh4VV8zdII= Authentication-Results: mxback13j.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp2o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id UQM3h4ayQX-YY4ehqO1; Mon, 08 Jul 2019 12:34:34 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-Mailer: geary/3.33.1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162318 Archived-At: > Thanks, I pushed this. >=20 > The log message was mis-formatted, which required me to tediously fix > it by hand. Please in the future format the entries using "C-x 4 a" > or similar commands, to avoid that, okay? In particular, lines longer > than 78 characters abort "git am", so please verify this doesn't > happen in the patches you submit. "C-x 4 a" and friends format the > entries with leading TABs which you can later remove with "C-x TAB", > and that produces the optimal results, including when the log messages > are later used to generate ChangeLog files in the release tarballs. Thank you! And sorry about that. I wanted to take a look this weekend=20 for problems you mentioned, but haven't got time. Anyway, IIRC I have=20 used "C-x 4 a" to create the commit message, but then I re-formatted it=20 to look more similar to other commits I've seen. Probably I shouldn't=20 have touched it=85 About git-am: this is unfortunate, I think I haven't seen this problem=20 because apparently "git" refuses to execute local hooks if one have set=20 global hooks with "hooksPath" variable (which since recently I use to=20 pre-format commit message based on modified paths, etc). I'll see what=20 can be done with it. P.S.: I replied on top level since for some reason my email client=20 (Geary) refused to reply the last message directly. =