From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#36250: [PATCH] Improve a bit frame-resize-pixelwise documentation Date: Fri, 28 Jun 2019 17:34:50 +0300 Message-ID: <1561732490.29740.1@yandex.ru> References: <1560707992.19774.0@yandex.ru> <20190618203502.31223-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161510"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36250@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 28 17:06:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgsS5-000fpc-F4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2019 17:06:13 +0200 Original-Received: from localhost ([::1]:32984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgsS4-0004PR-FJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2019 11:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42715) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgryv-0000ag-9X for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 10:36:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgryt-0003cY-36 for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 10:36:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57436) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgryr-0003c6-P6 for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 10:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgryr-00057Z-LR for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 10:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2019 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36250 X-GNU-PR-Package: emacs Original-Received: via spool by 36250-submit@debbugs.gnu.org id=B36250.156173250719589 (code B ref 36250); Fri, 28 Jun 2019 14:36:01 +0000 Original-Received: (at 36250) by debbugs.gnu.org; 28 Jun 2019 14:35:07 +0000 Original-Received: from localhost ([127.0.0.1]:42747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgrxy-00055s-Gx for submit@debbugs.gnu.org; Fri, 28 Jun 2019 10:35:06 -0400 Original-Received: from forward101p.mail.yandex.net ([77.88.28.101]:55375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgrxt-000558-3p for 36250@debbugs.gnu.org; Fri, 28 Jun 2019 10:35:04 -0400 Original-Received: from mxback6g.mail.yandex.net (mxback6g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:167]) by forward101p.mail.yandex.net (Yandex) with ESMTP id EF4083280C99; Fri, 28 Jun 2019 17:34:52 +0300 (MSK) Original-Received: from smtp4p.mail.yandex.net (smtp4p.mail.yandex.net [2a02:6b8:0:1402::15:6]) by mxback6g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id rZbzHL4Sop-Yq5CcG4L; Fri, 28 Jun 2019 17:34:52 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1561732492; bh=1x8An2ef3V5hvc/uWOS55lr6k3psrUdmbsYht81Ny+A=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=dAkZFLbK81Uzr+puHIkX67rtcz/Jm7nx5ca28qi1vXJjVRH4XBy/Qf656Zorj4CXF 1S9fKkqUTHV4RgxSh1QRyVVVzstu5QcUcDqZBAcn8UYWocelqVI60Rcyy17UpJHJ5i F/cGG044dLVZEXNQN6QM5Ta2TAoe7UoEQd9oOkFI= Authentication-Results: mxback6g.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp4p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id KCvxaAreoT-Yp3qnUSO; Fri, 28 Jun 2019 17:34:51 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) In-Reply-To: <83woh5hjrv.fsf@gnu.org> X-Mailer: geary/3.33.1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161728 Archived-At: =C2 =CF=F2, =E8=FE=ED 28, 2019 at 17:22, Eli Zaretskii =20 =ED=E0=EF=E8=F1=E0=EB: >> Date: Fri, 28 Jun 2019 16:59:45 +0300 >> From: Konstantin Kharlamov >> Cc: 36250@debbugs.gnu.org >>=20 >> > I think you read "resize a frame" and "set the size of a frame" as >> > referring to the same operation. But they aren't: the former is=20 >> about >> > changing the size of an existing frame with a mouse or with >> > set-frame-size, whereas the latter is about doing other things=20 >> that >> > implicitly require the frame's size to have pixel resolution. >> > >> > So no, this is not repetition, and should not be removed. >>=20 >> Right, but the 1st paragraph also says "If this is non-nil, [=85]=20 >> frame >> sizes can increase/decrease by one pixel". >=20 > Yes, but it doesn't say you can _set_ the size at pixel granularity to > begin with. >=20 >> I.e. this says that setting the variable to non-nil makes further >> operations on frames to have one-pixel resolution >=20 > That's your interpretation, but the text doesn't say that, it says > something slightly different. Thus the second paragraph is not > repetition. Ah, I think I see, you probably read the "to non-nil in order to set the size of a frame in pixels" as "to a numeric value in order to set the size of a frame in pixels". I had such interpretation too in mind. However note that=20 frame_resize_pixelwise in C code is mostly used as a boolean. The only=20 place where it's used as a numeric variable are 2 lines in src/widget.c: 276: ew->core.width =3D (frame_resize_pixelwise 279: ew->core.height =3D (frame_resize_pixelwise In particular, if you look at the patch that started the topic, you'll=20 find out that its value is not currently used to set width/height of a=20 frame: instead it's either 1 or line-height/column-width. =