From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: Robert Pluim <rpluim@gmail.com>
Cc: 36167@debbugs.gnu.org
Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]]
Date: Tue, 11 Jun 2019 16:17:10 +0300 [thread overview]
Message-ID: <1560259030.21373.0@yandex.ru> (raw)
In-Reply-To: <m2ftogxojb.fsf@gmail.com>
On Вт, июн 11, 2019 at 15:03, Robert Pluim <rpluim@gmail.com>
wrote:
>>>>>> On Tue, 11 Jun 2019 15:29:25 +0300, Konstantin Kharlamov
>>>>>> <Hi-Angel@yandex.ru> said:
>
> If this is fixing a bug, then please put '(Bug#36167)' somewhere in
> the commit message (I normally put it as the last thing in the
> preamble, before the detailed list of changes). See 'Commit messages'
> in CONTRIBUTE for extensive documentation.
>
> Konstantin> * etc/schema/od-schema-v1.2-os.rnc: replace
> Konstantin> [0-9a-fA-F] with [[:xdigit:]]
>
> This is the org schema file for OpenDocument export, not emacs
> lisp. Does that support :xdigit: syntax?
Oh, okay, thanks, I couldn't figure out what it is because Wikipedia
says that .rnc is just a variation of XML, and README just says it's
something to map some xml schemas to documents. So I deemed these
regexps are too used by ELisp.
Can I test it somehow? Either way, not a big deal, I can just drop that
one.
> Konstantin> * lisp/calc/calc-aent.el: replace [0-9a-fA-F] with
> Konstantin> [[:xdigit:]]
>
> Normally, you'd mention the containing function in the ChangeLog
> entry. Using 'C-x 4 a' (ie 'add-change-log-entry-other-window') with
> point on the code youʼre changing does that for you.
Ah, thanks. At this point I'll probably ask on emacs-devel about adding
to prepare-commit-msg a code to pre-format the changes, because clearly
that's a lot of manual work for something that should be automated.
> Konstantin> * lisp/calc/calc-ext.el: replace [0-9a-fA-F] with
> Konstantin> [[:xdigit:]]
>
> And then on subsequent similar changes you can say 'Likewise.' (whilst
> still mentioning the enclosing function)
>
> Konstantin> * lisp/calc/calc-lang.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/cedet/semantic/java.el: replace [0-9a-fA-F]
> with [[:xdigit:]]
> Konstantin> * lisp/cedet/semantic/lex.el: replace [0-9a-fA-F]
> with [[:xdigit:]]
> Konstantin> * lisp/emulation/cua-rect.el: replace [0-9a-fA-F]
> with [[:xdigit:]]
> Konstantin> * lisp/gnus/gnus-art.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/gnus/mml-sec.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/gnus/nneething.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/international/mule-cmds.el: replace
> [0-9a-fA-F] with [[:xdigit:]]
> Konstantin> * lisp/net/shr-color.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/nxml/rng-cmpct.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/nxml/rng-uri.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/nxml/rng-xsd.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/nxml/xmltok.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/org/org-mobile.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/progmodes/ada-mode.el: replace [0-9a-fA-F]
> with [[:xdigit:]]
> Konstantin> * lisp/progmodes/cc-mode.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/progmodes/cperl-mode.el: replace [0-9a-fA-F]
> with [[:xdigit:]]
> Konstantin> * lisp/progmodes/ebnf-dtd.el: replace [0-9a-fA-F]
> with [[:xdigit:]]
> Konstantin> * lisp/progmodes/hideif.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/progmodes/prolog.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/textmodes/css-mode.el: replace [0-9a-fA-F]
> with [[:xdigit:]]
> Konstantin> * lisp/textmodes/sgml-mode.el: replace [0-9a-fA-F]
> with [[:xdigit:]]
> Konstantin> * lisp/version.el: replace [0-9a-fA-F] with
> [[:xdigit:]]
> Konstantin> * lisp/xml.el: replace [0-9a-fA-F] with [[:xdigit:]]
> Konstantin> * test/src/emacs-module-tests.el: replace [0-9a-fA-F]
> with [[:xdigit:]]
>
> Robert
next prev parent reply other threads:[~2019-06-11 13:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 11:59 bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Konstantin Kharlamov
2019-06-11 12:03 ` bug#36167: Acknowledgement ([PATCH] Replace manually crafted hex regexes with [[:xdigit:]]) Konstantin Kharlamov
2019-06-11 12:29 ` bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Konstantin Kharlamov
2019-06-11 13:03 ` Robert Pluim
2019-06-11 13:17 ` Konstantin Kharlamov [this message]
2019-06-11 13:30 ` Robert Pluim
2019-06-12 0:29 ` Konstantin Kharlamov
2019-06-12 2:42 ` Eli Zaretskii
2019-06-12 8:21 ` Robert Pluim
2019-06-12 11:19 ` Konstantin Kharlamov
2019-06-12 14:55 ` Eli Zaretskii
2019-06-12 16:39 ` Konstantin Kharlamov
2019-06-12 16:51 ` Eli Zaretskii
2019-06-12 17:09 ` Konstantin Kharlamov
2019-06-12 21:33 ` Lars Ingebrigtsen
2019-06-12 21:39 ` Lars Ingebrigtsen
2019-06-12 22:17 ` Andreas Schwab
2019-06-12 22:22 ` Lars Ingebrigtsen
2019-06-12 22:48 ` Konstantin Kharlamov
2019-06-11 13:32 ` npostavs
2019-06-11 14:36 ` Eli Zaretskii
2019-06-11 14:26 ` bug#36167: [PATCH] Replace manually crafted hex regexes " Paul Eggert
2019-06-11 14:37 ` Konstantin Kharlamov
2019-06-11 15:37 ` Paul Eggert
2019-06-11 16:31 ` Mattias Engdegård
2019-06-11 16:50 ` Drew Adams
2019-06-11 17:04 ` Eli Zaretskii
2019-06-11 17:18 ` Paul Eggert
2019-06-11 17:32 ` Eli Zaretskii
2019-06-11 17:19 ` Drew Adams
2019-06-11 17:34 ` Eli Zaretskii
2019-06-11 17:50 ` npostavs
2019-06-11 17:53 ` Eli Zaretskii
2019-06-11 18:14 ` Eli Zaretskii
2019-06-11 19:56 ` Andy Moreton
2019-06-12 2:30 ` Eli Zaretskii
2019-06-12 11:44 ` Andy Moreton
2019-06-12 16:07 ` Eli Zaretskii
2019-06-13 0:18 ` bug#36167: [PATCH v2] Replace manually crafted hex regexes wth [[:xdigit:]] Konstantin Kharlamov
2019-07-06 8:04 ` Eli Zaretskii
2019-07-08 9:34 ` bug#36167: [PATCH v2] Replace manually crafted hex regexes with [[:xdigit:]] Konstantin Kharlamov
2019-07-08 12:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560259030.21373.0@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=36167@debbugs.gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).