* bug#8679: 24.0.50; wrong isearch highlighting for mismatch
[not found] ` <<837g91ty7t.fsf@gnu.org>
@ 2014-02-11 16:58 ` Drew Adams
2014-02-11 20:11 ` Juri Linkov
0 siblings, 1 reply; 8+ messages in thread
From: Drew Adams @ 2014-02-11 16:58 UTC (permalink / raw)
To: Eli Zaretskii, Drew Adams; +Cc: 8679, larsi
> Why is that a bug? What do you get with this simplified recipe?
>
> emacs -Q
> C-s eZZZZ
>
> When you type 'e', all the 'e's in the buffer are highlighted, but
> the 'e' in the echo area is highlighted in pink.
It depends where you start the search. If you start with point
at eob then what you say is true.
If you start the search at bob then the `e' is not pink when you
just type `e'. When you then type `ZZZZ', so your search string is
now `eZZZZ', the buffer highlighting disappears (there are no
matches).
The mismatched portion of your search string, which is the `ZZZZ'
portion, is highlighted pink, to show that it is a mismatch.
This is the correct (intended) behavior.
> As soon as you type the first 'Z', the highlight in the buffer goes
> away, and the whole "eZ" in the echo area is colored in pink.
See above.
> And that is what I would expect.
It might be all we can reasonably expect; I don't know. Probably
Juri can answer that. And yes, in that case this is probably
also the answer to the bug fix request: it might not be easy to
fix.
But the intended behavior of the pink highlighting is to highlight
the mismatch portion of the search string. What this means is that
there is a bug - the intention is not to highlight also the matched
portion. It may not be a bug that we can fix, but it is a bug.
> What you seem to expect happens when the search wraps around, but no
> such wrap-around happens in your recipe.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#8679: 24.0.50; wrong isearch highlighting for mismatch
@ 2011-05-16 20:36 Drew Adams
2011-05-16 21:57 ` Juri Linkov
2014-02-09 6:43 ` Lars Ingebrigtsen
0 siblings, 2 replies; 8+ messages in thread
From: Drew Adams @ 2011-05-16 20:36 UTC (permalink / raw)
To: 8679
In this case the mismatch highlighting is inaccurate:
emacs -Q
C-x b *scratch*
C-s ZZZZ
The entire search string is highlighted as a mismatch, which is correct.
M-e M-a e
So the edited search string is eZZZZ.
C-s
The entire search string, `eZZZZ' is highlighted, even though there are
matches for the `e'.
Not sure there is an easy fix for this one. And it's not very
important. But worth logging for future reference, at least.
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-05-10 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#8679: 24.0.50; wrong isearch highlighting for mismatch
2011-05-16 20:36 Drew Adams
@ 2011-05-16 21:57 ` Juri Linkov
2011-05-16 22:13 ` Drew Adams
2014-02-09 6:43 ` Lars Ingebrigtsen
1 sibling, 1 reply; 8+ messages in thread
From: Juri Linkov @ 2011-05-16 21:57 UTC (permalink / raw)
To: Drew Adams; +Cc: 8679
> Not sure there is an easy fix for this one. And it's not very
> important. But worth logging for future reference, at least.
Currently it has exactly the same behavior as you asked in
http://thread.gmane.org/gmane.emacs.devel/74539/focus=74614
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#8679: 24.0.50; wrong isearch highlighting for mismatch
2011-05-16 21:57 ` Juri Linkov
@ 2011-05-16 22:13 ` Drew Adams
0 siblings, 0 replies; 8+ messages in thread
From: Drew Adams @ 2011-05-16 22:13 UTC (permalink / raw)
To: 'Juri Linkov'; +Cc: 8679
> > Not sure there is an easy fix for this one. And it's not very
> > important. But worth logging for future reference, at least.
>
> Currently it has exactly the same behavior as you asked in
> http://thread.gmane.org/gmane.emacs.devel/74539/focus=74614
Not as I _asked_, but as I _stated_ was probably "as good as it gets". To which
I added, "but I'm open, if someone has a better idea". I said "I don't know how
to fix that."
Actually, I forgot about that bug thread. ;-)
This time I'm saying something similar, but the use case is different. What I
said before is still true, but this report is about the behavior after `M-e', so
the consideration about a buffer change doesn't really apply.
IOW, both observations are relevant, I think. For this use case (same buffer
where `M-e' was used), it might be good if after editing the matching part were
not highlighted as a mismatch. Again, dunno whether that would be an easy fix -
I doubt it, but maybe you have an idea.
I have no good idea about this. Do you?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#8679: 24.0.50; wrong isearch highlighting for mismatch
2011-05-16 20:36 Drew Adams
2011-05-16 21:57 ` Juri Linkov
@ 2014-02-09 6:43 ` Lars Ingebrigtsen
2014-02-11 15:23 ` Drew Adams
1 sibling, 1 reply; 8+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-09 6:43 UTC (permalink / raw)
To: Drew Adams; +Cc: 8679
"Drew Adams" <drew.adams@oracle.com> writes:
> In this case the mismatch highlighting is inaccurate:
>
> emacs -Q
>
> C-x b *scratch*
>
> C-s ZZZZ
>
> The entire search string is highlighted as a mismatch, which is correct.
>
> M-e M-a e
>
> So the edited search string is eZZZZ.
>
> C-s
>
> The entire search string, `eZZZZ' is highlighted, even though there are
> matches for the `e'.
Seems to work for me. Closing.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#8679: 24.0.50; wrong isearch highlighting for mismatch
2014-02-09 6:43 ` Lars Ingebrigtsen
@ 2014-02-11 15:23 ` Drew Adams
2014-02-11 16:23 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Drew Adams @ 2014-02-11 15:23 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 8679
> > In this case the mismatch highlighting is inaccurate:
> >
> > emacs -Q
> > C-x b *scratch*
> > C-s ZZZZ
> >
> > The entire search string is highlighted as a mismatch, which is
> > correct.
> >
> > M-e M-a e
> >
> > So the edited search string is eZZZZ.
> >
> > C-s
> >
> > The entire search string, `eZZZZ' is highlighted, even though
> > there are matches for the `e'.
>
> Seems to work for me. Closing.
Seems to work for you apparently means little, I'm afraid.
Still a bug on Windows, at least. The only difference in the
recipe now is that you need not use M-a. The point is that
after inserting `e' at the front of the search string, `C-s'
still highlights the whole search string, `eZZZZ', instead of
highlighting only the mismatch portion, `ZZZZ'.
Should be reopened and fixed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#8679: 24.0.50; wrong isearch highlighting for mismatch
2014-02-11 15:23 ` Drew Adams
@ 2014-02-11 16:23 ` Eli Zaretskii
0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2014-02-11 16:23 UTC (permalink / raw)
To: Drew Adams; +Cc: 8679, larsi
> Date: Tue, 11 Feb 2014 07:23:26 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: 8679@debbugs.gnu.org
>
> > > In this case the mismatch highlighting is inaccurate:
> > >
> > > emacs -Q
> > > C-x b *scratch*
> > > C-s ZZZZ
> > >
> > > The entire search string is highlighted as a mismatch, which is
> > > correct.
> > >
> > > M-e M-a e
> > >
> > > So the edited search string is eZZZZ.
> > >
> > > C-s
> > >
> > > The entire search string, `eZZZZ' is highlighted, even though
> > > there are matches for the `e'.
> >
> > Seems to work for me. Closing.
>
> Seems to work for you apparently means little, I'm afraid.
>
> Still a bug on Windows, at least. The only difference in the
> recipe now is that you need not use M-a. The point is that
> after inserting `e' at the front of the search string, `C-s'
> still highlights the whole search string, `eZZZZ', instead of
> highlighting only the mismatch portion, `ZZZZ'.
Why is that a bug? What do you get with this simplified recipe?
emacs -Q
C-s eZZZZ
When you type 'e', all the 'e's in the buffer are highlighted, but the
'e' in the echo area is highlighted in pink. As soon as you type the
first 'Z', the highlight in the buffer goes away, and the whole "eZ"
in the echo area is colored in pink. And that is what I would expect.
What you seem to expect happens when the search wraps around, but no
such wrap-around happens in your recipe.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-02-11 20:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <<066C4D0D5E9344B6AA56A2F57400BE27@us.oracle.com>
[not found] ` <<87r47c7plr.fsf@building.gnus.org>
[not found] ` <<715a78fd-35fb-41de-b523-5f86484a0369@default>
[not found] ` <<837g91ty7t.fsf@gnu.org>
2014-02-11 16:58 ` bug#8679: 24.0.50; wrong isearch highlighting for mismatch Drew Adams
2014-02-11 20:11 ` Juri Linkov
2011-05-16 20:36 Drew Adams
2011-05-16 21:57 ` Juri Linkov
2011-05-16 22:13 ` Drew Adams
2014-02-09 6:43 ` Lars Ingebrigtsen
2014-02-11 15:23 ` Drew Adams
2014-02-11 16:23 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).