unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: npostavs@gmail.com
Cc: 35368@debbugs.gnu.org
Subject: bug#35368: [PATCH v3] Do potentially destructive operations in prepare-commit-msg
Date: Thu, 16 May 2019 00:28:58 +0300	[thread overview]
Message-ID: <1557955738.20091.0@yandex.ru> (raw)
In-Reply-To: <85k1erwr8r.fsf@gmail.com>



В Ср, мая 15, 2019 at 13:40, npostavs@gmail.com написал:
> Konstantin Kharlamov <Hi-Angel@yandex.ru> writes:
> 
>>  * build-aux/git-hooks/prepare-commit-msg: if someone occasionally 
>> puts
>>  Signed-off line, it will likely get there through -s option of git.
>>  Exploit this fact to abort before a user got a chance to type commit
>>  message.
> 
> Thanks, looks good, but I think it would be helpful to explain that 
> this
> is about catching git commit -s ... in the comments of the file too.
> 
>>  --- a/autogen.sh
>>  +++ b/autogen.sh
>>  @@ -1,4 +1,4 @@
>>  -#!/bin/sh
>>  + #!/bin/sh
> 
> This is a typo or something, right?

Oh, right, sorry about that. It wasn't supposed to get into the commit. 
I was testing the hook by adding this space, and apparently it leaked 
through to my local commit.

Thanks for your comments, I resent a v4 with a comment added, and the 
stray space removed.







  parent reply	other threads:[~2019-05-15 21:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-21 20:03 bug#35368: [PATCH] Do potentially destructive operations in prepare-commit-msg Konstantin Kharlamov
2019-04-21 20:17 ` bug#35368: [PATCH v2] " Konstantin Kharlamov
2019-05-14 17:33   ` npostavs
2019-05-14 21:22     ` Konstantin Kharlamov
2019-05-14 22:09       ` Noam Postavsky
2019-05-14 22:15         ` Konstantin Kharlamov
2019-05-14 22:26         ` bug#35368: [PATCH v3] " Konstantin Kharlamov
2019-05-15 17:40           ` npostavs
2019-05-15 21:25             ` bug#35368: [PATCH v4] " Konstantin Kharlamov
2019-05-17  0:35               ` Noam Postavsky
2019-05-17  0:39                 ` Konstantin Kharlamov
2019-05-15 21:28             ` Konstantin Kharlamov [this message]
     [not found] ` <handler.35368.B.155587702222113.ack@debbugs.gnu.org>
2019-04-23  9:57   ` bug#35368: Acknowledgement ([PATCH] Do potentially destructive operations in prepare-commit-msg) Konstantin Kharlamov
2019-04-23 10:40     ` Eli Zaretskii
2019-04-23 10:43     ` Basil L. Contovounesios
2019-04-23 11:00       ` Konstantin Kharlamov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1557955738.20091.0@yandex.ru \
    --to=hi-angel@yandex.ru \
    --cc=35368@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).