From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35368: [PATCH v2] Do potentially destructive operations in prepare-commit-msg Date: Wed, 15 May 2019 00:22:02 +0300 Message-ID: <1557868922.32614.0@yandex.ru> References: <20190421200313.26202-1-Hi-Angel@yandex.ru> <20190421201730.30905-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="107982"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35368@debbugs.gnu.org To: npostavs@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 14 23:23:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQetO-000RwZ-6J for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 23:23:22 +0200 Original-Received: from localhost ([127.0.0.1]:54565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQetN-0002sk-7v for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 17:23:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQetG-0002sX-Ln for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 17:23:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQet7-0007qY-C4 for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 17:23:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36534) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQet4-0007oA-CW for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 17:23:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQet4-0005xR-6S for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 17:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 21:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35368 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35368-submit@debbugs.gnu.org id=B35368.155786893522835 (code B ref 35368); Tue, 14 May 2019 21:23:02 +0000 Original-Received: (at 35368) by debbugs.gnu.org; 14 May 2019 21:22:15 +0000 Original-Received: from localhost ([127.0.0.1]:50078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQesJ-0005wF-9K for submit@debbugs.gnu.org; Tue, 14 May 2019 17:22:15 -0400 Original-Received: from forward106j.mail.yandex.net ([5.45.198.249]:60910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQesG-0005vp-Cb for 35368@debbugs.gnu.org; Tue, 14 May 2019 17:22:13 -0400 Original-Received: from mxback14o.mail.yandex.net (mxback14o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::65]) by forward106j.mail.yandex.net (Yandex) with ESMTP id 2712311A1D0C; Wed, 15 May 2019 00:22:04 +0300 (MSK) Original-Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [2a02:6b8:0:1a2d::27]) by mxback14o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id JFVeH9fFQx-M3I0md0Z; Wed, 15 May 2019 00:22:04 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1557868924; bh=N0zOqLxK3g7EE0QF4LVUndzVZjL9Yg617IRnSWWZNG4=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=mIYKZHU+lULkuUENUPRbYeBh//iqFaM2sG6exApzb8IhwAQZk7Dnf5cyz6BIlc2ZX DcGR0+h2SmaKUvfPrruzoQVsjdSvSnNFu0jxjfAIUNMFApErT+Kj0IHb989z9d262A 1LSrp4Ny8a5GN8oUPk4QJ9Ho7Nv3fiBqQ4coDwSE= Authentication-Results: mxback14o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id Ut4GqTVwJK-M3f4XpLC; Wed, 15 May 2019 00:22:03 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) In-Reply-To: <85pnolvt4d.fsf@gmail.com> X-Mailer: geary/3.33.1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159292 Archived-At: =F7 =F7=D4, =CD=C1=D1 14, 2019 at 13:33, npostavs@gmail.com =CE=C1=D0=C9=D3= =C1=CC: > Konstantin Kharlamov writes: >=20 >> +# Use a UTF-8 locale if available, so that the UTF-8 check works. >> +# Use U+00A2 CENT SIGN to test whether the locale works. >> +cent_sign_utf8_format=3D'\302\242\n' >> +cent_sign=3D`printf "$cent_sign_utf8_format"` >> +print_at_sign=3D'BEGIN {print substr("'$cent_sign'@", 2)}' >> +at_sign=3D`$awk "$print_at_sign" /dev/null` >> +if test "$at_sign" !=3D @; then >> + at_sign=3D`LC_ALL=3Den_US.UTF-8 $awk "$print_at_sign" > 2>/dev/null` >> + if test "$at_sign" =3D @; then >> + LC_ALL=3Den_US.UTF-8 >> + else >> + LC_ALL=3DC >> + fi >> + export LC_ALL >> +fi >> + >> +exec $awk -v at_sign=3D"$at_sign" -v cent_sign=3D"$cent_sign" -v=20 >> file=3D"$COMMIT_MSG_FILE" ' >=20 > You don't actually need any of this at_sign and cent_sign stuff here,=20 > right? Well, I honestly don't know. I didn't want to break some odd emacs=20 development usecase, so I took that part of code from the current=20 `commit-msg`. And if you think it's unnecessary, then it's unnecessary=20 as well in the current `commit-msg`. =