From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Mon, 15 Apr 2019 18:01:35 +0300 Message-ID: <1555340495.24928.3@yandex.ru> References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1326"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org, rms@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 15 17:02:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hG37m-00006b-8r for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 17:02:22 +0200 Original-Received: from localhost ([127.0.0.1]:51451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG37l-0005ql-5o for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 11:02:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG37U-0005m8-Hs for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 11:02:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG37S-0003ma-VH for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 11:02:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49923) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hG37S-0003mL-Q0 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 11:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hG37S-0000y1-Kd for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 11:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2019 15:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.15553405113697 (code B ref 35062); Mon, 15 Apr 2019 15:02:02 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 15 Apr 2019 15:01:51 +0000 Original-Received: from localhost ([127.0.0.1]:35234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG37H-0000xZ-HF for submit@debbugs.gnu.org; Mon, 15 Apr 2019 11:01:51 -0400 Original-Received: from forward101p.mail.yandex.net ([77.88.28.101]:60139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG37F-0000xJ-0H for 35062@debbugs.gnu.org; Mon, 15 Apr 2019 11:01:50 -0400 Original-Received: from mxback2o.mail.yandex.net (mxback2o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1c]) by forward101p.mail.yandex.net (Yandex) with ESMTP id 07FAF32807B1; Mon, 15 Apr 2019 18:01:39 +0300 (MSK) Original-Received: from smtp4o.mail.yandex.net (smtp4o.mail.yandex.net [2a02:6b8:0:1a2d::28]) by mxback2o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id JSpKV9RuBC-1cni0nV9; Mon, 15 Apr 2019 18:01:39 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1555340499; bh=uTe5UDT1TSxyMR83AGNShA23eZPbSndQohfMIx/POVA=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=CaZDNVfNIy4rLiq/RZ7Bn36jpl8vrgrZFdT5grZCFbVIOwkT5Ylw4RSbr+xfDpVWp puHpUIlB3WoV+vTcPu4r3fCHUN4ILG51XlvBh0o1TX/vDjcysZ8Fzn7/ImxShDPkSz notE6EfnLm2tIOgzx7rN9XHUt5koVb1XtRTn/Dcg= Authentication-Results: mxback2o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp4o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id Jz5jo2tUMk-1bfmP15b; Mon, 15 Apr 2019 18:01:37 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <83mukribkk.fsf@gnu.org> X-Mailer: geary/mainline~g7970b668 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157660 Archived-At: On =D0=9F=D0=BD, Apr 15, 2019 at 17:32, Eli Zaretskii wrote: >> Date: Mon, 15 Apr 2019 09:49:08 +0300 >> From: Konstantin Kharlamov >> Cc: Eli Zaretskii , 35062@debbugs.gnu.org >>=20 >> IMO in such situations (i.e. when original changes were commited >> without any modification anyway) would be nice to commit the=20 >> original >> patch, and then add up further improvements as 2-nd commit. >=20 > That's true, but this is not such a situation: the original changes > were never committed without any modifications. Well, given the line my patch modifies has no changes, the only=20 modification was the commit message. My only mistake was not knowing=20 that UTF8 is prohibited. But really, it's a 2 symbols text replacement,=20 me or you could just replace it. > Sometimes committing the original and then making changes in a > followup is TRT, and sometimes it isn't; it's a judgment call. In > general, the decision depends on the percentage of the original > submission that the committer would like to change, and also on the > overall volume of the original submission. In this case, the original > patch was relatively small, and I modified it in relatively > significant ways. So it made little sense to commit something that > would be immediately modified in significant ways, it would just be > extra work for no good reason. Is there an extra work? The changes you added can be commited with =CE=B1)=20 git commit --amend -v, or =CE=B2) git commit -v. You did =CE=B1, which only= =20 differs from =CE=B2 by a number of characters, that is ironically smaller=20 in =CE=B2. >> Ultimately what makes me sad is that if I'd want to refer to my >> commits in Emacs as part of a CV, it's hard to find all suggested-by >> and authored commits at the same time, and also that suggested-by >> sounds kind of vague to have an influence in CV. >=20 > You can always use "git log --grep" to find references to your > contributions in the log messages. And the log message includes a > reference to the bug number, where you can refer people for your > actual contribution. Who would attach a bunch of commit messages to a CV? It's unreliable=20 (interviewer gotta check that these indeed are mine), and also they=20 gonna bloat CV for no reason. A better way would be providing a=20 web-link to a repository with commits. ---- Sorry, I actually feel embarassed that I discussing a trivial one-liner=20 patch :D But I can't stop thinking that this could've happened with a=20 non-one-line or maybe one-line but non-trivial contribution=E2=80=A6 =