From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Sat, 13 Apr 2019 21:19:12 +0300 Message-ID: <1555179552.11233.0@yandex.ru> References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="251341"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 13 20:20:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFNG5-0013HW-QV for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2019 20:20:10 +0200 Original-Received: from localhost ([127.0.0.1]:54550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFNG4-0006rt-Qn for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2019 14:20:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFNFz-0006ri-5O for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 14:20:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFNFy-0000Yd-1g for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 14:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hFNFx-0000YE-Tb for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 14:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hFNFx-0006cb-Lo for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 14:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2019 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155517956425407 (code B ref 35062); Sat, 13 Apr 2019 18:20:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 13 Apr 2019 18:19:24 +0000 Original-Received: from localhost ([127.0.0.1]:59097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFNFM-0006bj-Iq for submit@debbugs.gnu.org; Sat, 13 Apr 2019 14:19:24 -0400 Original-Received: from forward106o.mail.yandex.net ([37.140.190.187]:55593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFNFK-0006bV-7M for 35062@debbugs.gnu.org; Sat, 13 Apr 2019 14:19:24 -0400 Original-Received: from mxback8o.mail.yandex.net (mxback8o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::22]) by forward106o.mail.yandex.net (Yandex) with ESMTP id E7D9E506050F; Sat, 13 Apr 2019 21:19:14 +0300 (MSK) Original-Received: from smtp4p.mail.yandex.net (smtp4p.mail.yandex.net [2a02:6b8:0:1402::15:6]) by mxback8o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id CDMQqR2wc7-JE7adMAi; Sat, 13 Apr 2019 21:19:14 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1555179554; bh=eAiq/8+K3S75uWZ40xQTokqz0A1+rlTpDxGPong/qK8=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=Z8jO7Qofyd0DsuA1+6zRgCyy6uJtqiy+eW8yJFcisYyRN3z8fNI2rN3hKhxRFKPZ3 S5O8ox3P0ymt19MCNq4IAvrTJC4s8g7z4lqcYUedEfAC+OngQuq2PR0HZLGOiVfEf5 bZLWMyoztVG0s3sH5gZ/bBtCgYbMs5qJN+nRhFTQ= Authentication-Results: mxback8o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp4p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id MYu7u8JTNY-JDa0dlNx; Sat, 13 Apr 2019 21:19:13 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <835zril476.fsf@gnu.org> X-Mailer: geary/master~g59ef85ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157587 Archived-At: =D0=92 =D0=A1=D0=B1, =D0=B0=D0=BF=D1=80 13, 2019 at 11:06, Eli Zaretskii =20 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB: >> From: Konstantin Kharlamov >> Date: Sun, 7 Apr 2019 05:13:29 +0300 >>=20 >> * src/xterm.c (x_set_frame_alpha): due to preceding checks it is=20 >> bound >> to be 0 =E2=89=A4 alpha =E2=89=A4 1. (Bug#35062) >> --- >> v3: mention functions changed in commit messages, mention the bug >> number, and don't mention that it fixes a warning since intention =20 >> of >> changes is clear either way. >=20 > Thanks, I pushed a slightly different change along the same lines. >=20 > A minor nit: please avoid using non-ASCII characters in log entries, > if that can be avoided, to cater to terminals that don't support UTF-8 > (the character you used is not in Latin-1). Err=E2=80=A6 I just looked at log =E2=80=94 wait, what?? There is no my pat= ch. You=20 crafted a patch of your own, incorporated my changes, and pushed as=20 your own. If I gonna pass someone this link=20 http://git.savannah.gnu.org/cgit/emacs.git/log/?qt=3Dauthor&q=3DKonstantin=20 there is no my contribution. More over: you didn't even tell me! Wow! This is not good. =