From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35224: [PATCH] include indentation size in .dir-locals Date: Thu, 11 Apr 2019 16:56:44 +0300 Message-ID: <1554991004.18502.5@yandex.ru> References: <20190411011046.28243-1-Hi-Angel@yandex.ru> <1554963878.18502.0@yandex.ru> <1554979143.18502.4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-5; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="78391"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35224@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 11 15:58:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEaDY-000KDA-5H for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 15:58:16 +0200 Original-Received: from localhost ([127.0.0.1]:49326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEaDX-0002ie-34 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 09:58:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEaDM-0002gw-KI for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 09:58:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEaDL-00072t-Fl for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 09:58:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41433) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEaDK-00071y-AU for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 09:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEaDK-0003FG-00 for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 09:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Apr 2019 13:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35224 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35224-submit@debbugs.gnu.org id=B35224.155499102212395 (code B ref 35224); Thu, 11 Apr 2019 13:58:01 +0000 Original-Received: (at 35224) by debbugs.gnu.org; 11 Apr 2019 13:57:02 +0000 Original-Received: from localhost ([127.0.0.1]:54977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEaCM-0003Dq-4P for submit@debbugs.gnu.org; Thu, 11 Apr 2019 09:57:02 -0400 Original-Received: from forward102j.mail.yandex.net ([5.45.198.243]:49858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEaCG-0003DD-Da for 35224@debbugs.gnu.org; Thu, 11 Apr 2019 09:56:58 -0400 Original-Received: from mxback14j.mail.yandex.net (mxback14j.mail.yandex.net [IPv6:2a02:6b8:0:1619::90]) by forward102j.mail.yandex.net (Yandex) with ESMTP id 94144F20570; Thu, 11 Apr 2019 16:56:46 +0300 (MSK) Original-Received: from smtp1j.mail.yandex.net (smtp1j.mail.yandex.net [2a02:6b8:0:801::ab]) by mxback14j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id QbByAcRaUl-ukW4dAci; Thu, 11 Apr 2019 16:56:46 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1554991006; bh=XNxIYlHpRpstQpmt30B0xOUVYnkPk3boF6FazNp1cGI=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=sOrX/YVBPXWzFoKpiGtBnXlumorks6hQHcd3kQTRBP2Nd2IwCqJ8V3xJ5AMxuEHPn KS9yx5UH+PIDOVaqVhlwYJxF7PHrAFLLhVq+sNmXR7hdpJYP5OYFRDgxKyoOh7IHVX 1Jmv1QbDkTucwFVJvLDSueiC1QchrLeXAp0gFqaE= Authentication-Results: mxback14j.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 0yqemcBZet-ujImgaJ3; Thu, 11 Apr 2019 16:56:45 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <87d0lsreoy.fsf@tcd.ie> X-Mailer: geary/mainline~g7970b668 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157496 Archived-At: On =C7=E2, Apr 11, 2019 at 11:58, Basil L. Contovounesios=20 wrote: > Konstantin Kharlamov writes: >=20 >> On =C7=E2, Apr 11, 2019 at 11:26, Basil L. Contovounesios=20 >> wrote: >>=20 >>> Globally setting c-basic-offset overrides the cc-mode style=20 >>> inheritance >>> system. There are various ways to customise this variable in a=20 >>> more >>> granular way, such as defining a custom style which inherits from a >>> built-in style, or setting c-basic-offset locally in a mode hook. >>> For details, see (info "(ccmode) Config Basics"). >>=20 >> Oh, okay, so this works as expected. But since googling "change=20 >> indentation >> size" always gives using specifically c-basic-offset (e.g. >> =20 >> https://stackoverflow.com/questions/14939608/how-to-change-emacs-struct-= indents-from-4-to-2-spaces), >> I guess it's safe to assume most of Emacs users has it changed. So=20 >> it's useful >> to add this to dir-locals anyway. >=20 > IMO, that's a bug in the configuration of those users because they're > overriding how cc-mode works, and the cc-mode manual describes in=20 > detail > the various ways to customise indentation. So I don't see a need to > change the Emacs dir-locals-file to accommodate this use-case. Okay, but we can't ignore the fact that such usecase exists and is=20 widely employed (if needed, I can throw more links to these advices on=20 stackexchange site). So let me ask: is there a downside to making this change? Because if=20 there's none then the change is an improvement, it's that simple. > But that's just one opinion, and I'm not familiar with prevailing=20 > policy > on what to add to the Emacs dir-locals-file. >=20 > -- > Basil =