From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions Date: Sat, 06 Apr 2019 01:18:38 +0300 Message-ID: <1554502718.25876.0@yandex.ru> References: <87ef6lic84.fsf@gmail.com> <20190402002327.28219-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="125578"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 06 00:19:50 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCXBe-000WZ6-3Z for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 00:19:50 +0200 Original-Received: from localhost ([127.0.0.1]:47562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCXBd-0004TO-3p for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 18:19:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCXAt-0004AV-OK for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 18:19:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCXAs-0006bc-Je for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 18:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32812) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCXAs-0006as-Ae for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 18:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCXAr-0005Xn-U4 for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 18:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2019 22:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155450272921293 (code B ref 35062); Fri, 05 Apr 2019 22:19:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 5 Apr 2019 22:18:49 +0000 Original-Received: from localhost ([127.0.0.1]:46356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCXAe-0005XM-Ry for submit@debbugs.gnu.org; Fri, 05 Apr 2019 18:18:49 -0400 Original-Received: from forward103p.mail.yandex.net ([77.88.28.106]:45074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCXAc-0005X7-1V for 35062@debbugs.gnu.org; Fri, 05 Apr 2019 18:18:47 -0400 Original-Received: from mxback6g.mail.yandex.net (mxback6g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:167]) by forward103p.mail.yandex.net (Yandex) with ESMTP id E7BE518C0066; Sat, 6 Apr 2019 01:18:39 +0300 (MSK) Original-Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback6g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id C26UQOoS6b-IdqWWZRU; Sat, 06 Apr 2019 01:18:39 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1554502719; bh=Fx89qpN2JeMvJEo1T0xfimIoxn0KrnX2mkkdp6JA0F0=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=LwYFQAdQuk9aBYkIa/4eQ/xgQO52we+0D29ARg25zgiLhueql3HqYm10VCXBdWoRV h4e7E1nhTmnAMKLy9LRJxALG7c/ux5uXKvOf1M1SXOh2T9O4+QBLP6ZiXfvzQswm8l cY4JXzVlKWe6zKwMLBUzFtxhcpWnOoGEhzWzKfSI= Authentication-Results: mxback6g.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 0aBae039Qn-IcM4kaRu; Sat, 06 Apr 2019 01:18:39 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <83bm1lc4ph.fsf@gnu.org> X-Mailer: geary/improve-conversation-loading-performance~gc359cbb7-dirty X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157239 Archived-At: On =CF=F2, Apr 5, 2019 at 10:05, Eli Zaretskii wrote: >> From: Konstantin Kharlamov >> Date: Tue, 2 Apr 2019 03:23:27 +0300 >>=20 >> * src/gtkutil.c: >> remove "always false" comparison >> remove multiplication by zero, it's a noop anyway >> remove min_cols and min_rows as it's now unused >>=20 >> Fixes LGTM warnings: >> * Comparison is always false because min_cols <=3D 0. >> * Comparison is always false because min_rows <=3D 0. >> --- >> v2: remove the min_rows/min_cols whatsoever >=20 > Thanks, pushed. Please in the future write the commit log messages in > the ChangeLog-like style, see CONTRIBUTE for the details. I did that > this time, you can look at what I pushed to see an example of that > style in action. Thanks, so, I'm looking right now to modify the rest of series and=20 resend it here, and=85 I think I miss something: the only difference of=20 my commit from CONTRIBUTE file is that I forgot to list the functions=20 changed. I think I misunderstand something, because you completely rewrote the=20 commit messages compared to mine. Titles now are more vague, and for=20 some reason you removed a note that one of patches fixes warnings in=20 the code. And then you also added "Bug#35062", even though there's no=20 bug (the report existence is incidental, it's because bugtracker is=20 used to track patches in Emacs. But writing "Bug" will only confuse=20 readers =97 there's no bug). =