unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Kozlov <kanichos@yandex.ru>
To: 36733 <36733@debbugs.gnu.org>
Subject: bug#36733: 27.0.50; Eshell taking long time to enter directory  after TAB completion
Date: Sat, 29 Feb 2020 10:56:40 +0300	[thread overview]
Message-ID: <1540741582963000@sas1-ffdbcd5f1d77.qloud-c.yandex.net> (raw)
In-Reply-To: <1503001582961076@iva6-22e79380f52c.qloud-c.yandex.net>

I was probably wrong about the apparent total unsuitability of the markers.

I just realised the issue with argument deletion can be fixed trivially:

--- /gnu/store/1ffhlsa973ym7j2zsyrbm892jxcpzmqq-emacs-next-27.0.50-0.36abf68/share/emacs/27.0.50/lisp/minibuffer.el.gz                                      
+++ #<buffer minibuffer.el.gz>                                                                                                                              
@@ -2132,6 +2132,7 @@                                                                                                                                       
       (and completion-in-region--data                                                                                                                      
            (and (eq (marker-buffer (nth 0 completion-in-region--data))                                                                                     
                     (current-buffer))                                                                                                                      
+               (< (nth 0 completion-in-region--data) (nth 1 completion-in-region--data))                                                                   
                 (>= (point) (nth 0 completion-in-region--data))                                                                                            
                 (<= (point)                                                                                                                                
                     (save-excursion                                                                                                                        

It works. I don’t know if it also breaks anything.

The problem with new line characters remains, but it really seems to be a different issue. In fact, can multi-line completion be useful in some cases? Maybe it is eshell that should tell the completion mode to stop when a command has been entered. I want to know how SPC works in the current scheme. RET should do the same in eshell.





  reply	other threads:[~2020-02-29  7:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19 21:21 bug#36733: 27.0.50; Eshell taking long time to enter directory after TAB completion Jean Louis
2019-07-20  7:16 ` Eli Zaretskii
2019-07-20  7:50   ` Jean Louis
2019-07-20  8:31     ` Eli Zaretskii
2019-07-20  9:07       ` Jean Louis
2019-07-20 10:08         ` Eli Zaretskii
2019-07-20 10:31           ` Jean Louis
2019-07-20 10:55             ` Eli Zaretskii
2019-07-20 15:28               ` Jean Louis
2019-07-20 15:56                 ` Eli Zaretskii
2019-07-20 16:22                   ` Jean Louis
2019-07-20 16:40                     ` Eli Zaretskii
2020-02-29  1:30 ` bug#36733: (no subject) Ivan Kozlov
2020-02-29  9:40   ` Ivan Kozlov
2020-02-29  3:51 ` bug#36733: 27.0.50; Eshell taking long time to enter directory after TAB completion Ivan Kozlov
2020-02-29  6:40   ` Ivan Kozlov
2020-02-29  7:24     ` Ivan Kozlov
2020-02-29  7:56       ` Ivan Kozlov [this message]
2020-02-29  9:02         ` Ivan Kozlov
2020-02-29  9:33         ` Ivan Kozlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1540741582963000@sas1-ffdbcd5f1d77.qloud-c.yandex.net \
    --to=kanichos@yandex.ru \
    --cc=36733@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).