From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nikolaus Rath Newsgroups: gmane.emacs.bugs Subject: bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces Date: Tue, 03 Jul 2018 08:40:59 +0100 Message-ID: <1530603659.1377875.1428249096.0D7BA8A9@webmail.messagingengine.com> References: <87efrlfa20.fsf@thinkpad.rath.org> <87a829f9pc.fsf@thinkpad.rath.org> <1504800077.365137.1098530944.678C4105@webmail.messagingengine.com> <87k212zetg.fsf@mouse.gnus.org> <877ewxoi32.fsf@vostro.rath.org> <87r2rfj2r7.fsf@mouse.gnus.org> <1527766712.3634038.1391649040.3CF55CA8@webmail.messagingengine.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1530603984 3183 195.159.176.226 (3 Jul 2018 07:46:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Jul 2018 07:46:24 +0000 (UTC) Cc: Andreas Schwab , 21057@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 03 09:46:20 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faG0v-0000gs-Ar for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jul 2018 09:46:17 +0200 Original-Received: from localhost ([::1]:38680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faG32-0002v9-Fm for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jul 2018 03:48:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faFwu-0007Nj-NZ for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 03:42:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faFwq-0006Xp-S8 for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 03:42:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1faFwq-0006XF-MN for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 03:42:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1faFwo-00049Y-BL; Tue, 03 Jul 2018 03:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nikolaus Rath Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Tue, 03 Jul 2018 07:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21057 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 21057-submit@debbugs.gnu.org id=B21057.153060366215891 (code B ref 21057); Tue, 03 Jul 2018 07:42:02 +0000 Original-Received: (at 21057) by debbugs.gnu.org; 3 Jul 2018 07:41:02 +0000 Original-Received: from localhost ([127.0.0.1]:44371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faFvq-00048F-Hz for submit@debbugs.gnu.org; Tue, 03 Jul 2018 03:41:02 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faFvo-00047h-SU for 21057@debbugs.gnu.org; Tue, 03 Jul 2018 03:41:01 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 707E021B2C; Tue, 3 Jul 2018 03:41:00 -0400 (EDT) Original-Received: from web2 ([10.202.2.212]) by compute1.internal (MEProxy); Tue, 03 Jul 2018 03:41:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=marcDy MohA8OyHQ4H+EfelQpouRiEvpd0T+kFPFxn80=; b=NBAbLbCseOlJiBlVlnkoWM x/ov4Aj5d//HsY16dudpaWd06kcGBkvsgSe6yi5aCeBD1mQcy/ul+o5lhVg7yWG1 GjKRfhX+Qa5VUPota140Dy7lUArwG1GoXo8PDHyVHFru2NN2VMgKt/aJ6yAdn5wP X7cVweMOujgckoy0mQwAywn49RoHaFjOWio/0zIa8Eus04/TDb46o/0dg2fKfVmR 8U8qf5Y3LtwQmqkkjFdSvn9uyLnNTNMDlYCCc6IlN28SYJGiGFYUF/LOd461Ll5S mMQKmNFEVEqjp3zscEGP9cs/DjE95UzePx1A0PAoiLcuwGH7KU0R2F7VRmzha9fg == X-ME-Proxy: X-ME-Sender: Original-Received: by mailuser.nyi.internal (Postfix, from userid 99) id 989BB621DC; Tue, 3 Jul 2018 03:40:59 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface - ajax-0d8ea36c In-Reply-To: <1527766712.3634038.1391649040.3CF55CA8@webmail.messagingengine.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148142 Archived-At: *ping* Could someone take a look at the revised patch? Thanks! -Nikolaus -- GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = =C2=BBTime flies like an arrow, fruit flies like a Banana.=C2=AB On Thu, 31 May 2018, at 12:38, Nikolaus Rath wrote: > Hi, >=20 > On Wed, 27 Dec 2017, at 22:10, Lars Ingebrigtsen wrote: > > Looks good, but a couple of niggles: > >=20 > > > +(setq nnimap-namespaces nil) > >=20 > > This should be a defvar, or rather, a defvoo. > >=20 > > [...] > >=20 > > > + (let* ((prefix (cadr (assoc (nnoo-current-server 'nnimap) > > > + nnimap-namespaces))) > > > + (inbox (substring prefix 0 -1))) > >=20 > > And then you could just set nnimap-namespaces without maintaining a > > per-server alist, since that's what the voo machinery does for you > > (switching out variables on a per-server basis). >=20 > Updated patches attached (and rebased onto current master). >=20 > Best, > -Nikolaus >=20 > -- > GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F >=20 > =C2=BBTime flies like an arrow, fruit flies like a Banana.= =C2=AB > Email had 3 attachments: > + 0001-nnimap.el-factor-out-nnimap-group-to-imap.patch > 9k (text/x-patch) > + 0002-nnimap.el-Add-support-for-IMAP-namespaces.patch > 10k (text/x-patch) > + 0003-Turn-nnimap-namespaces-into-a-defvoo-to-make-it-per-.patch > 4k (text/x-patch)