From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: David Malcolm Newsgroups: gmane.emacs.bugs Subject: bug#25987: 25.2; support gcc fixit notes Date: Fri, 16 Mar 2018 12:48:07 -0400 Message-ID: <1521218887.2913.237.camel@redhat.com> References: <87lgsj1jle.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1521220031 11579 195.159.176.226 (16 Mar 2018 17:07:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Mar 2018 17:07:11 +0000 (UTC) To: 25987@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 16 18:07:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewsos-0002ud-H9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Mar 2018 18:07:06 +0100 Original-Received: from localhost ([::1]:58640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewsqv-0001Ux-Jr for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Mar 2018 13:09:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewsqp-0001UY-ET for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 13:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewsqk-0004aI-Fu for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 13:09:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewsqk-0004a3-Bx for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 13:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewsqk-00030s-1F for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 13:09:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87lgsj1jle.fsf@tromey.com> Resent-From: David Malcolm Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Mar 2018 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25987 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25987-submit@debbugs.gnu.org id=B25987.152122009111520 (code B ref 25987); Fri, 16 Mar 2018 17:09:01 +0000 Original-Received: (at 25987) by debbugs.gnu.org; 16 Mar 2018 17:08:11 +0000 Original-Received: from localhost ([127.0.0.1]:37229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewspv-0002zk-D0 for submit@debbugs.gnu.org; Fri, 16 Mar 2018 13:08:11 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:43590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewsWc-0002X9-53 for 25987@debbugs.gnu.org; Fri, 16 Mar 2018 12:48:14 -0400 Original-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 810B57FEB5 for <25987@debbugs.gnu.org>; Fri, 16 Mar 2018 16:48:08 +0000 (UTC) Original-Received: from ovpn-117-5.phx2.redhat.com (ovpn-117-5.phx2.redhat.com [10.3.117.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E9B06375A for <25987@debbugs.gnu.org>; Fri, 16 Mar 2018 16:48:08 +0000 (UTC) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 16 Mar 2018 16:48:08 +0000 (UTC) X-Mailman-Approved-At: Fri, 16 Mar 2018 13:08:10 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144333 Archived-At: [I'm not familiar with this bug-tracking system; let's see if this works] I'm the author of the -fdiagnostics-parseable-fixits feature in GCC; I maintain the GCC diagnostics subsystem. As Tom(?) noted, I made -fdiagnostics-parseable-fixits report in bytes, partly because that's the status quo for all of GCC's "column" reporting, and partly because that's what clang implemented for this. It appears that Emacs can already decode from byte-offsets in a line back to columns, so this seems like a compatibility detail in case we fix everything to use real column numbers. I'm also an Emacs user (though not a Emacs developer, sorry; my Lisp is practically non-existent) - I just wondered what the status of this is. I'm keen to be able to use it (GCC will get better faster!), even if it's just a new command in compilation mode to go ahead and apply a fix-it hint for the current diagnostic, as seen by next-error, if it has one, maybe prettifying the printing of such lines, with the user having to manually supply -fdiagnostics-parseable-fixits somehow. FWIW GCC 8 is gaining lots more fix-it hints (including ones that add newlines, for missing "#include" suggestions); see: https://developers.redhat.com/blog/2018/03/15/gcc-8-usability-improvements/ for a blog post I wrote about it. Thanks; hope this is constructive. Dave