unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Rankin <hello@paulwrankin.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 28844@debbugs.gnu.org, agrambot@gmail.com
Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook
Date: Tue, 17 Oct 2017 17:13:46 +1000	[thread overview]
Message-ID: <1508224426.2790345.1141279648.61B955E6@webmail.messagingengine.com> (raw)
In-Reply-To: <06925BCF-6C99-423B-AB13-E7331E22B867@gnu.org>

On Tue, 17 Oct 2017, at 03:44 PM, Eli Zaretskii wrote:
> First, let's be clear about something: it's not "my" mode.  I'll never use it, except
> for testing and fixing bugs.  I implemented this feature because line numbers are
> very popular among Emacs users, and existing solutions, like linum-mode, slow
> down Emacs, sometimes to a crawl.  The excitement expressed by users on Reddit
> when the feature landed, which surprised me, is a clear evidence that the results
> are very satisfactory, as far as users are
> concerned.  So this feature is here to
> stay, and Lisp packages need to adapt (bundled packages already did, AFAIK).
> 
> Next, I *know* that I'm misunderstanding something, but repeating what you
> already said, twice, won't help me understand it.  Please provide more
> details about your application's needs regarding the window layout.

https://github.com/rnkn/olivetti

Here’s the minor mode. Go nuts.

> Given the little that you said until now, would checking the value returned by
> line-number-display-width in a post-command-hook solve your problem?
> If not, please tell why not, and let's take it from there.

No it wouldn’t. I don’t need to run code after every command. Until now, the following hooks have been perfect:

window-configuration-change-hook
window-size-change-functions
after-setting-font-hook
text-scale-mode-hook

n.b. window-size-change-functions only added recently due to 26.x changes.





  reply	other threads:[~2017-10-17  7:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-15  7:56 bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook Paul Rankin
2017-10-15  9:41 ` martin rudalics
2017-10-15 11:08   ` Paul Rankin
2017-10-15 12:12     ` martin rudalics
2017-10-15 13:27       ` Paul Rankin
2017-10-15 14:59         ` Eli Zaretskii
2017-10-16  3:22           ` Paul Rankin
2017-10-16  4:59             ` Alex
2017-10-16  5:14               ` Paul Rankin
2017-10-16 14:48                 ` Eli Zaretskii
2017-10-17  0:35                   ` Paul Rankin
2017-10-17  2:41                     ` Eli Zaretskii
2017-10-17  4:19                       ` Paul Rankin
2017-10-17  5:44                         ` Eli Zaretskii
2017-10-17  7:13                           ` Paul Rankin [this message]
2017-10-17  8:33                             ` Eli Zaretskii
2017-10-20  9:42                               ` Eli Zaretskii
2017-12-08  2:43                             ` Noam Postavsky
2017-12-08 14:48                               ` Eli Zaretskii
2017-12-09 15:30                               ` Paul Rankin
2017-12-09 16:01                                 ` Eli Zaretskii
2017-10-15 14:47       ` Eli Zaretskii
2017-10-16  7:41         ` martin rudalics
2017-10-22  7:20 ` Paul Rankin
2017-10-22 14:27   ` Eli Zaretskii
2017-12-08  2:14 ` Paul Rankin
2017-12-08 15:22   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508224426.2790345.1141279648.61B955E6@webmail.messagingengine.com \
    --to=hello@paulwrankin.com \
    --cc=28844@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).