From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Rankin Newsgroups: gmane.emacs.bugs Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook Date: Sun, 15 Oct 2017 21:08:37 +1000 Message-ID: <1508065717.3534312.1139251176.600E646A@webmail.messagingengine.com> References: <1508054203.3504379.1139170720.0D0E99E9@webmail.messagingengine.com> <59E32D49.4030007@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1508065769 16543 195.159.176.226 (15 Oct 2017 11:09:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 15 Oct 2017 11:09:29 +0000 (UTC) Cc: 28844@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 15 13:09:23 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3gn3-0001C3-6g for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 13:09:05 +0200 Original-Received: from localhost ([::1]:56820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3gnA-0000CE-Ee for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 07:09:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3gn4-0000Bu-AX for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 07:09:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3gn1-0007DG-4P for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 07:09:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3gn0-0007D3-SD for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 07:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3gn0-0007eX-HN for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 07:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Rankin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Oct 2017 11:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28844-submit@debbugs.gnu.org id=B28844.150806572129386 (code B ref 28844); Sun, 15 Oct 2017 11:09:02 +0000 Original-Received: (at 28844) by debbugs.gnu.org; 15 Oct 2017 11:08:41 +0000 Original-Received: from localhost ([127.0.0.1]:41001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3gmf-0007du-4I for submit@debbugs.gnu.org; Sun, 15 Oct 2017 07:08:41 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3gmd-0007dk-KC for 28844@debbugs.gnu.org; Sun, 15 Oct 2017 07:08:39 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7C8AC20BC9; Sun, 15 Oct 2017 07:08:37 -0400 (EDT) Original-Received: from web5 ([10.202.2.215]) by compute3.internal (MEProxy); Sun, 15 Oct 2017 07:08:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paulwrankin.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0hvqPkToHSdt1ODcd m/dE4lnDTLHIXNBqaqTffLccBQ=; b=uaSB8/oSGeX7yzV+//WUbBYNjFwQu91dr G5/3ae3uIgg3bhtGXWfxpdhObLrTUTlhtGbgZN9FvBtA4bRtRHArN2Av6aris2gn ntpr84gjaFUFsOcpCCxsfI8kOcJj70KRjCbY6UpoYFetx+Ucn2inNjUPlT9wim4R SSyswGPtYSxHjf2dI2FYx/LmZJ2Sjf8ifMnJ6iUqDjwPs3S7TJoUvXOx9HHjb11b 9eZ797Z4JJdc95eb2ZilKbPj4OaxmLoqR6de6t+BeSkiN42jZ89VcIvOUi2MVTtK K5VU+0NyrW/C3OPB0m2VtYVqP7D17m5wUTpXlNzDQpsj82QlyKlvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0hvqPk ToHSdt1ODcdm/dE4lnDTLHIXNBqaqTffLccBQ=; b=L7/CC7mdk147j8UA3l2vnP pA2+Iz0V/A5NxmlSebEMobJ9bLR01UEAlq2mJQC5WSIv+FvIa3bdm0hcgzxKS9FJ mPJnLypOk6Xqy4qxdt2NxoLUrwf2mUM7PxoaS3mA80dgoaAj8Fl8WiCS/C5BqfZ9 4bdWlpz0Et68mS0FHOQxMMLqBxyLQlEFqpicbkZd6ZA37D4xbeRBuckr96L2UbNK JuGxufoTtdLKWzbkZHr4kOTHOjVaCOdHejdSl4uWiYTdg7QF2fVco69Ez6KWKKZz SgwoNWTV58skAMmVVosiRLXLnFnSpirWtEtrGDQlBU2nUNtSJ7Hr8v+/KoqZD1ag == X-ME-Sender: Original-Received: by mailuser.nyi.internal (Postfix, from userid 99) id 53CE79E2EE; Sun, 15 Oct 2017 07:08:37 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface - ajax-26fdae60 In-Reply-To: <59E32D49.4030007@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138450 Archived-At: On Sun, 15 Oct 2017, at 07:41 PM, martin rudalics wrote: > > Activating/deactivating display-line-numbers-mode alters the window > > configuration and so should call window-configuration-change-hook but > > does not. >=20 > =E2=80=98window-configuration-change-hook=E2=80=99 is still run way too o= ften, for > example, when windows get resized. =E2=80=98window-size-change-functions= =E2=80=99 might > be better. But if you need such a hook, wouldn't you also need it when > line numbers occupy more or less columns, for example, during scrolling? >=20 > Otherwise, why can't you use =E2=80=98display-line-numbers-mode-hook=E2= =80=99? Thanks for pointing me to display-line-numbers-mode-hook, but I=E2=80=99ve = found that it=E2=80=99s not enough to just check when the mode is enabled. = We need to alert other concerned modes whenever display-line-numbers-mode c= hanges the margins, e.g. due to scrolling from line 99 to 100 (which will i= ncrease the width from 2 to 3).