From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47711: bug#48841: bug#47711: bug#48841: bug#47711: [PATCH VERSION 2] Add new `completion-filter-completions` API and deferred highlighting Date: Fri, 27 Oct 2023 20:06:11 +0300 Message-ID: <1504b2e4-42d9-5d7b-eaa2-c7b7d5ca02ba@gutov.dev> References: <3d3f894f-a6fa-53ae-5d50-c3aa9bffc73e@daniel-mendler.de> <56ab18b1-4348-9b2c-85bb-af9b76cd429a@daniel-mendler.de> <328f87eb-6474-1442-e1ca-9ae8deb2a84a@yandex.ru> <83fsvcbio7.fsf@gnu.org> <9f432d18-e70f-54c1-0173-1899fb66d176@gutov.dev> <877cnafv39.fsf@gmail.com> <9447dde3-b8e7-2ec0-9a9c-72c4cf9d12a8@gutov.dev> <7d14bc13-4419-816c-5708-c42988c39c02@gutov.dev> <5d0a78cc-4fa0-ef04-3462-1826f17d7d56@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9979"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Daniel Mendler , Eli Zaretskii , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 47711@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 27 19:06:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qwQIS-0002LN-Jn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Oct 2023 19:06:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwQI5-0003u2-4r; Fri, 27 Oct 2023 13:06:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwQI3-0003tj-R2 for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2023 13:06:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwQI3-0004Mv-64 for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2023 13:06:31 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qwQIY-00067E-7e for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2023 13:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Oct 2023 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47711 X-GNU-PR-Package: emacs Original-Received: via spool by 47711-submit@debbugs.gnu.org id=B47711.169842641723496 (code B ref 47711); Fri, 27 Oct 2023 17:07:02 +0000 Original-Received: (at 47711) by debbugs.gnu.org; 27 Oct 2023 17:06:57 +0000 Original-Received: from localhost ([127.0.0.1]:37010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwQIT-00066t-1f for submit@debbugs.gnu.org; Fri, 27 Oct 2023 13:06:57 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:52299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwQIP-00066b-6m for 47711@debbugs.gnu.org; Fri, 27 Oct 2023 13:06:55 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 6F55B5C0248; Fri, 27 Oct 2023 13:06:16 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 27 Oct 2023 13:06:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1698426376; x=1698512776; bh=L6Iwc1Rwt2N+bYgCrKARi4fP7npiBmJau6X sKQi3mpE=; b=foTsF5EcuYcV1e5My5qhUf7/YQddsGsiOiWerhryRdRFTPZjOIZ iJCnezetdt7GBwTdloSjS7Kc/i5u6kuariOxDzPHKEIW+Vo1uXd/bf8j55dIbJ0N Jw0WtyqhHvqIjHIV0poNR5k4CC12A1F49pQ3E9amwjbmL9kSR56Yi3qHOy6k6qpz xwaqRpqmV6HFDt7gUkaWMjWO+Qhn7D9vJGR/cRvsAOtRj8nvBzSE9XmaxYtNU99D 39Nru05/694ssXPSYzjOPtSG9CRqjxXRFen3MjJyl4lQ7w7Wv5753GcvVDAUJVPi jMbuhgLrbNgwKqXex0E7XFlS+Gb020zxS2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698426376; x=1698512776; bh=L6Iwc1Rwt2N+bYgCrKARi4fP7npiBmJau6X sKQi3mpE=; b=st113GdfSLoBkAl6BupOlmqG+lgTNZTjhKNh/7t+UDtDk0NIgyi rbtY6OW03V6vVKyGnsITl0ui0kQvlGuRHf+GEa5AJ2VAju6FV4+MioNXzNBO/VD2 dYX2gj25qjQc6caOINGcSIefSDdpVluw+64ZgNeDAhxPOFGD3CVuy8D2EjhEVH3y LvnBy/GiVEf5rA6HqES9z27ECPKhzhtwWJlzY/2gvRDpq7xdfUE7hgXAeV39gM1Q 9Dr6MXWrw7432QEEZS5FjkDbJBR2shPrMJ+MRWTuU1xuwgNEtHn9+hU1uQlwccc/ t+7QzMNTiGpsZ5DG5NzJ632pjA698W9Lffg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrleeggddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Oct 2023 13:06:13 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273393 Archived-At: On 27/10/2023 19:19, Stefan Monnier wrote: >> We could, for example, have a period when we warn about returned >> non-matches. string-match-p is not free, but it's not very expensive either. > > The problem is that I dislike `completion-regexp-list` :-) When we do use it, we can avoid copying all the strings to a new list. Skipping consing this way can really move the needle at the level of optimization we're discussing now. > More seriously, since it's a dynbound variable it can have unwanted > effects in nested calls to `all/try-completions`, so it's safer to > ignore that variable because its binding is not always "meant for us" :-( I guess it would be more precise if it was a function argument, e.g. the first argument to 'fancy-all-completions' or somesuch that all completion tables are supposed to use inside. OTOH, I suppose that might hinder those that use external programs.