From: Paul Eggert <eggert@cs.ucla.edu>
To: Phil Sainty <psainty@rcon.net.nz>
Cc: 42931@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>,
Bruno Haible <bruno@clisp.org>,
Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#42931: 27.1; json-pretty-print-buffer on ~2MB line causes core dump
Date: Mon, 24 Aug 2020 16:46:01 -0700 [thread overview]
Message-ID: <14e2aff5-20e3-03a3-50ae-cfabee5bc406@cs.ucla.edu> (raw)
In-Reply-To: <0b9da4d7-ca24-8e00-d49f-7630e42abe89@orcon.net.nz>
The patch I installed into Emacs master for Bug#43016 also fixes Bug#42931's
test case, at least for me. However, Bug#42931 prompted me to change the way
that the Gnulib diffseq module recurses so that the stack size is O(log N)
rather than O(N). I installed this change into Gnulib, here:
https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=7aadb23803a8fb71d07e6e87ffb1ca510d86f8ef
and propagated this into Emacs master, here:
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d494f9e81a6d11dcf6c22333cd950989b2051dff
I doubt whether this patch needs to be backported into the emacs-27 branch.
In theory even O(log N) might not be good enough if Emacs has a tiny stack and a
huge buffer, but I doubt whether this is of practical concern.
I'll cc this to Bruno Haible to give him a heads-up, since he created the
diffseq module. Bruno, the bug report is here:
https://bugs.gnu.org/42931
next prev parent reply other threads:[~2020-08-24 23:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 13:50 bug#42931: 27.1; json-pretty-print-buffer on ~2MB line causes core dump Phil Sainty
2020-08-19 14:15 ` Lars Ingebrigtsen
2020-08-19 15:18 ` Eli Zaretskii
2020-08-20 13:22 ` Lars Ingebrigtsen
2020-08-20 13:26 ` Philipp Stephani
2020-08-20 13:39 ` Eli Zaretskii
2020-08-24 23:46 ` Paul Eggert [this message]
2020-08-25 6:12 ` Eli Zaretskii
2020-08-25 18:19 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14e2aff5-20e3-03a3-50ae-cfabee5bc406@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=42931@debbugs.gnu.org \
--cc=bruno@clisp.org \
--cc=larsi@gnus.org \
--cc=p.stephani2@gmail.com \
--cc=psainty@rcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).