From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Rankin Newsgroups: gmane.emacs.bugs Subject: bug#27634: 25.2.1; C-g does not quit register-read-with-preview Date: Tue, 11 Jul 2017 14:14:22 +1000 Message-ID: <1499746462.2451911.1036820704.00105E22@webmail.messagingengine.com> References: <1499659134.3804557.1035526184.45B0CA20@webmail.messagingengine.com> <87h8ykdcmx.fsf@calancha-pc> <1499671255.3837111.1035640480.1DBD693E@webmail.messagingengine.com> <83shi4i5ma.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1499746525 17273 195.159.176.226 (11 Jul 2017 04:15:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 11 Jul 2017 04:15:25 +0000 (UTC) Cc: tino.calancha@gmail.com, 27634@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 11 06:15:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUmZr-0003o4-Jd for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jul 2017 06:15:12 +0200 Original-Received: from localhost ([::1]:44062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUmZx-0005TL-4o for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jul 2017 00:15:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUmZm-0005PM-Ay for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 00:15:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUmZj-0006fz-5K for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 00:15:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUmZj-0006fn-1D for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 00:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dUmZi-00032f-Qt for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 00:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Rankin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jul 2017 04:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27634 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27634-submit@debbugs.gnu.org id=B27634.149974646411633 (code B ref 27634); Tue, 11 Jul 2017 04:15:02 +0000 Original-Received: (at 27634) by debbugs.gnu.org; 11 Jul 2017 04:14:24 +0000 Original-Received: from localhost ([127.0.0.1]:33218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUmZ6-00031Y-7O for submit@debbugs.gnu.org; Tue, 11 Jul 2017 00:14:24 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUmZ4-00031R-VV for 27634@debbugs.gnu.org; Tue, 11 Jul 2017 00:14:23 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6BB9B20B67; Tue, 11 Jul 2017 00:14:22 -0400 (EDT) Original-Received: from web5 ([10.202.2.215]) by compute3.internal (MEProxy); Tue, 11 Jul 2017 00:14:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paulwrankin.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=JgBBf1gs/myq9Gop2 k7CQuUhkkK+qE0UrbTkiq58vHY=; b=DcO2o6I/7XmXQbC8YrFkerCUfSiw3/sYN Xm4c6+H8Mqo/z2KxRaA4RfJEBi9qZXY/GwfBAGretU2eWP6P2BR7QVqa8+/zocAG q6cgASln9gvCSdrStYcvd0HNBCigvgUoLK1SAHMYaUlmWFb+55Q3/DS2seLIcncn OWawAylpokaxNcrdwuTIZL2TOdqTV+Kl6T7uWqFncnT26hfYIX6xhfD9MlqZiLbH eFeziXhqn/xaBD0D0rIfAeapbb2Pt7JYPIdybs5A7M/1It79mPzgdaPNo0SYn2vP 3UJhXupUqrKt7T953XDjHIR762KSSP9UITjUn/4+XnlQYk1t1ZTVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=JgBBf1 gs/myq9Gop2k7CQuUhkkK+qE0UrbTkiq58vHY=; b=S3SFblWKnlmgv3qt5h0xta ZcmvBSt3QCGw+BOZ4qOUCVagaRKfd/ZLOOVckionwpDRqkSO6ofaf9l/b20IncuY QeYIA00Ogo1rP37on/2yMc+7JK4egBrUlLa795XhOvTppOXnY0E/XkeUHbx/dCZR SlQvi1QTztfxLfSNgcbB2tZedOflqIHo7y5huN3rjHAaOV7s7U/hOGRfrucjEMnD J7P/+a77l+BtiRmnGTUqptfzMluA0zY5KkWEI/t0nLTQykLbNHZJp8h1me/nbD1m NMvX1qDHu2BG2sG3BM1Vr2jwphXojGQzT+gVHMPXS0jVaPxgwAOBrMLi+CXqlmBg == X-ME-Sender: Original-Received: by mailuser.nyi.internal (Postfix, from userid 99) id 43B9D9E2A7; Tue, 11 Jul 2017 00:14:22 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface - ajax-6ef673f5 In-Reply-To: <83shi4i5ma.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134420 Archived-At: On Tue, 11 Jul 2017, at 03:06 AM, Eli Zaretskii wrote: > FWIW, I actually agree with Tino's solution, and was about to propose > something similar. It's true that control characters are not > alphanumeric, but we could fix the documentation to be more accurate > if we care about that. OTOH, we've supported control characters as > register names for many years, and by now it should be quite clear it > didn't bother anyone yet. Hmm, it bothers me? If no one had reported an issue before now, it doesn't then follow that the issue didn't bother anyone, or, wouldn't have bothered them if they knew about it. But the question is moot I think, since this is an opportunity to improve the code.. why waste time arguing for poorer code when we can make it better? > > That prohibits anything except "a-zA-Z0-9", although users may want to save registers to "$" or "*". > > Why would we want to be so strict when the only real problem is that > C-g doesn't quit? I think there are two good options for good UX: make the code reflect the documentation (this is the strict option), or update both the documentation and the code to reflect what we believe is user expectation, i.e. that the user may save registers to any character key on their keyboard (this is my preference). One overlooked thing about Tino's solution is that C-g is a keystroke and keyboard-quit is a function, which obviously aren't necessarily equivalent. What if the user remaps keyboard quit to "7"?