From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Rankin Newsgroups: gmane.emacs.bugs Subject: bug#27634: 25.2.1; C-g does not quit register-read-with-preview Date: Mon, 10 Jul 2017 17:20:55 +1000 Message-ID: <1499671255.3837111.1035640480.1DBD693E@webmail.messagingengine.com> References: <1499659134.3804557.1035526184.45B0CA20@webmail.messagingengine.com> <87h8ykdcmx.fsf@calancha-pc> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1499671586 21821 195.159.176.226 (10 Jul 2017 07:26:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 10 Jul 2017 07:26:26 +0000 (UTC) Cc: 27634@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 10 09:26:23 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUT5I-0005HU-40 for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jul 2017 09:26:20 +0200 Original-Received: from localhost ([::1]:38989 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUT5L-0004YN-RT for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jul 2017 03:26:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUT0B-0000aV-HG for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2017 03:21:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUT0A-000136-Ca for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2017 03:21:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56810) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUT0A-00012y-8j for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2017 03:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dUT0A-0005lP-4M for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2017 03:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Rankin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jul 2017 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27634 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27634-submit@debbugs.gnu.org id=B27634.149967125822125 (code B ref 27634); Mon, 10 Jul 2017 07:21:02 +0000 Original-Received: (at 27634) by debbugs.gnu.org; 10 Jul 2017 07:20:58 +0000 Original-Received: from localhost ([127.0.0.1]:59487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUT06-0005kn-3Q for submit@debbugs.gnu.org; Mon, 10 Jul 2017 03:20:58 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUT04-0005kf-Ll for 27634@debbugs.gnu.org; Mon, 10 Jul 2017 03:20:57 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 10521206C8; Mon, 10 Jul 2017 03:20:56 -0400 (EDT) Original-Received: from web5 ([10.202.2.215]) by compute3.internal (MEProxy); Mon, 10 Jul 2017 03:20:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paulwrankin.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=x/F3JwYeMm5cQ05yG UMV2GKIyAERKeJsizpL4NcEHOs=; b=OCi0dNfj6pKiC2YHsdl+7o21Vk8r60hFs uQSIOYuQMGvCv7SIBQRQmygt+GfR5hjivxnvnFsOUEapShKBcwlFo8jTW9UXE6qe 8cEPCKQ198eWWOej/cT8BaVhd9Ex/PsF1gD4+zFGx9UPYrRBpeWd7DZrODWf5R7+ bLWMJ/pWV6mYKiI3SkahHVGX9+lE6c0h6CZl01fnYAYK1S3fYpWqc2Wf/9lwFLnq MHx8vCze+K2sH4dW+FAvedjblm1NnoIKp0T1Q3oD0IzxG3W2XZf+1TzhXVlkvAYc j7MU5f74MyFnKc90/2UgsdVMEvEqozWndjWtDKcAjKfSPRjDf/nAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=x/F3Jw YeMm5cQ05yGUMV2GKIyAERKeJsizpL4NcEHOs=; b=aYhn8qa1cTF4r3SnMuv1wW 8/RLojve47HpYEKZlhMEoUlOulV7fvlUJnDR+8cXTs3IvDSU5TA/mXNdx0vYLcRC ufBiBI0ygYM7usxSUkyzBhufHhcSgK0qT1hEZ52UyIh1ztjxMg1HMD93c7WXOcY1 nsaFk2YvDDaizZsIPjSp5SmI41URjcCzB1MIWxtmx6MUDybTeK+fHVku1lbOUjgA eB6zg7ZZ9eUZzFJnDbIFJTcisp5PT0andt+8+RJ4BHUMpQz5WgDPMwC2ae61/SKC WB2MAbT9c2fah6M9g7e/Q/2c2c5x/UW/dp4rwoNNYuRaR5faFNedTfPMBnFdiZVQ == X-ME-Sender: Original-Received: by mailuser.nyi.internal (Postfix, from userid 99) id D28689E2B4; Mon, 10 Jul 2017 03:20:55 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface - ajax-6ef673f5 In-Reply-To: <87h8ykdcmx.fsf@calancha-pc> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134387 Archived-At: On Mon, 10 Jul 2017, at 04:33 PM, Tino Calancha wrote: > How about the following? > > @@ -164,6 +164,8 @@ register-read-with-preview > help-chars) > (unless (get-buffer-window buffer) > (register-preview buffer 'show-empty))) > + (when (eq (string-to-char "\C-g") last-input-event) > + (keyboard-quit)) > (if (characterp last-input-event) last-input-event > (error "Non-character input-event"))) > (and (timerp timer) (cancel-timer timer)) I think that's more a bandaid than fixing the root of the problem, which is that the manual tells the user that register names are alphanumeric characters (and I assume 99% of users only use alphanumeric characters) but the function doesn't test for this. e.g. testing for C-g doesn't catch for ^L or ^M, etc. If we want to be strict about it, this might work: @@ -164,8 +164,8 @@ help-chars) (unless (get-buffer-window buffer) (register-preview buffer 'show-empty))) - (if (characterp last-input-event) last-input-event - (error "Non-character input-event"))) + (if (= (char-syntax last-input-event) 119) last-input-event + (error "Register name must be alphanumeric"))) (and (timerp timer) (cancel-timer timer)) (let ((w (get-buffer-window buffer))) (and (window-live-p w) (delete-window w))) That prohibits anything except "a-zA-Z0-9", although users may want to save registers to "$" or "*".