unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Simen Heggestøyl" <simenheg@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 27363@debbugs.gnu.org
Subject: bug#27363: 26.0.50; Error with customize-group
Date: Fri, 16 Jun 2017 19:34:27 +0200	[thread overview]
Message-ID: <1497634467.28243.0@smtp.gmail.com> (raw)
In-Reply-To: <popoe6w5zn.fsf@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

On Thu, Jun 15, 2017 at 12:37 AM, Glenn Morris <rgm@gnu.org> wrote:
> This is the same thing as http://debbugs.gnu.org/25640; ie fallout 
> from
> plist-put changes.
> 
> Although the :options field for css-electric-keys seems pointless 
> anyway,
> since the repeat type doesn't support it. (Same for 
> compilation-environment.)

Right. Does the attached patch look sufficient?

-- Simen

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Remove-meaningless-options-usage-in-defcustoms.patch --]
[-- Type: text/x-patch, Size: 1537 bytes --]

From bdbb0ea2ea88c507fadb971cdd68c2dc6002c77f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@gmail.com>
Date: Fri, 16 Jun 2017 19:24:31 +0200
Subject: [PATCH] Remove meaningless :options usage in defcustoms
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The :options keyword argument isn’t currently meaningful for the
repeat type.

* lisp/progmodes/compile.el (compilation-environment):
* lisp/textmodes/css-mode.el (css-electric-keys): Remove :options
argument.
---
 lisp/progmodes/compile.el  | 1 -
 lisp/textmodes/css-mode.el | 1 -
 2 files changed, 2 deletions(-)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 31ec5a67d0..29ed0f1523 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -732,7 +732,6 @@ compilation-environment
 This list is temporarily prepended to `process-environment' prior to
 starting the compilation process."
   :type '(repeat (string :tag "ENVVARNAME=VALUE"))
-  :options '(("LANG=C"))
   :group 'compilation
   :version "24.1")
 
diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el
index 0beaaaa32f..e657abc959 100644
--- a/lisp/textmodes/css-mode.el
+++ b/lisp/textmodes/css-mode.el
@@ -764,7 +764,6 @@ css-electric-keys
   "Self inserting keys which should trigger re-indentation."
   :version "22.2"
   :type '(repeat character)
-  :options '((?\} ?\;))
   :group 'css)
 
 (defvar css-mode-syntax-table
-- 
2.11.0


  reply	other threads:[~2017-06-16 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 19:24 bug#27363: 26.0.50; Error with customize-group Simen Heggestøyl
2017-06-14 22:37 ` Glenn Morris
2017-06-16 17:34   ` Simen Heggestøyl [this message]
2017-06-17  0:32     ` Glenn Morris
2017-06-19 18:55       ` Glenn Morris
2017-06-20 19:01         ` Simen Heggestøyl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497634467.28243.0@smtp.gmail.com \
    --to=simenheg@gmail.com \
    --cc=27363@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).