From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Mon, 01 May 2017 21:15:31 +0200 Message-ID: <1493666131.1965.0@smtp.gmail.com> References: <87mvefh8br.fsf@tromey.com> <1485375833.1960.0@smtp.gmail.com> <1485455113.4245.1@smtp.gmail.com> <1487359774.1998.0@smtp.gmail.com> <1488653191.6153.0@smtp.gmail.com> <1488738524.13864.0@smtp.gmail.com> <871str3b48.fsf@tromey.com> <1490812056.14782.1@smtp.gmail.com> <1492873665.3376.0@smtp.gmail.com> <87lgqpyl6y.fsf@pokyo> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Trace: blaine.gmane.org 1493666171 13070 195.159.176.226 (1 May 2017 19:16:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 May 2017 19:16:11 +0000 (UTC) Cc: 25525@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 01 21:16:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5Gnl-0003GX-Eh for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 May 2017 21:16:05 +0200 Original-Received: from localhost ([::1]:55481 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5Gnr-0007uc-2F for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 May 2017 15:16:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5Gnl-0007uV-6t for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 15:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5Gnh-0001Td-WB for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 15:16:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51732) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5Gnh-0001TX-RM for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 15:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d5Gnh-0001C9-JW for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 15:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2017 19:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.14936661424566 (code B ref 25525); Mon, 01 May 2017 19:16:01 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 1 May 2017 19:15:42 +0000 Original-Received: from localhost ([127.0.0.1]:49931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5GnN-0001Ba-SX for submit@debbugs.gnu.org; Mon, 01 May 2017 15:15:42 -0400 Original-Received: from mail-lf0-f52.google.com ([209.85.215.52]:34930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5GnM-0001BM-EU for 25525@debbugs.gnu.org; Mon, 01 May 2017 15:15:40 -0400 Original-Received: by mail-lf0-f52.google.com with SMTP id 75so64286621lfs.2 for <25525@debbugs.gnu.org>; Mon, 01 May 2017 12:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=lSYv31zd4PgGHRZcAlUjghsLHZmw6sx5qJaiI4DGCIg=; b=fyTpeEiyOz9ubw629UNLZ0ln3/bBtsZl6LOOL98V6LT/a1V2gN5W+HCZTUHNBpk3jK J3aOyE/zFOhQ9HIvB1c7C3vQfcuwwgw6jkTlVUjgCl+02T/IeteDyDMsEghS/XQeKHcP OZqd0+nIVNT3nb1Gvlb/8+aFZdEAQEXS2TJ3qcWiWPCSMTpjBYXhRh7rvItKRXJGhQ1i sSiJQSoAX/fg0ymr3Om77x68Z8yOFJiBoEXZBJv9U3kuE3hP86RR9fO+YIajcLYhOSYq Yn0jqJg7vM8d2mGFt4ZUkBz/bcNy7A9Yw/4U3ETQFYKaF3yvm/DMriFZdXkCufYpTa+L 0spQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=lSYv31zd4PgGHRZcAlUjghsLHZmw6sx5qJaiI4DGCIg=; b=H23VE2VQT9voO82/PLsjpUt5N6dqBB0JaJXNHcv7ci+ZMJOB+N9LBmKW7PapN+vEA+ Zx/PCRUvkTzFbDnrF3pUvgp+2ReQ2zPdP8c7wdvUQm8r1GuKm5nxsgBCsZSUJa8VhfXN JeR5a1SgRVhwJoElIcTRdDmSL7dKLIjhhTjI3GEdw0c+5+nExnN4XDdDZInWMMgT8yB9 j+VBB2ol9/EBZ8qLBelPpB945q680s3A0xnXviejppEhWBsARRLBFrLyZgbty4LMFJ5c 7wY4TS2yePBFs4/NdWQ2iWpN3Oo11iKPbnMDyG8T3XzQMtnw5g3Jczx2psQrzU3YYQdk RQ7Q== X-Gm-Message-State: AN3rC/4ZrAS77CXDAwExjpfk4HKpYEwNkfAocUoo+pQ1/BONlPvXpFHb yhTRBramdvBimPhq X-Received: by 10.46.20.7 with SMTP id u7mr8626209ljd.66.1493666134161; Mon, 01 May 2017 12:15:34 -0700 (PDT) Original-Received: from [192.168.100.12] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id b8sm2789349lfg.32.2017.05.01.12.15.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 May 2017 12:15:33 -0700 (PDT) In-Reply-To: <87vapn3l0i.fsf@tromey.com> X-Mailer: geary/0.11.3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132171 Archived-At: On Sat, Apr 29, 2017 at 6:17 AM, Tom Tromey wrote: > Tom> I finally was, I will look into it soon. Thanks again. > > This patch on top of my current patch was enough. However I'm not > sure > it is the best way. It does pass the css mode tests, but I'm also not > sure that is sufficient. Could you try it out? I'm not sure either, but it does seem to fix the issue. I haven't discovered any more issues since last time, so the feature seems good to go as far as I'm concerned! -- Simen