unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Simen Heggestøyl" <simenheg@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: 25525@debbugs.gnu.org
Subject: bug#25525: 25.1.90; add color highlighting to css mode
Date: Sat, 22 Apr 2017 17:07:45 +0200	[thread overview]
Message-ID: <1492873665.3376.0@smtp.gmail.com> (raw)
In-Reply-To: <874lxi5sxt.fsf@tromey.com>

Hi Tom, thanks for this update.

On Fri, Apr 21, 2017 at 5:40 AM, Tom Tromey <tom@tromey.com> wrote:
> Sorry about the delay on this.  I've been busy with other things.

No problem.

> Let me know what you think.  I appreciate you taking the time to try
> this out.

I think it's starting to look very good (I hope you're not getting
discouraged by my nitpickery).

The problem with SCSS variable names remains for me, even with the
newest patch. See the following image:
http://folk.uio.no/simenheg/tmp/screenshot-2017-04-22-16-53-25.png.

Are you able to reproduce it? I think that's the last important problem
to fix before we land this.

> FWIW I've been using this in my work.  It works with mhtml-mode, so 
> I've
> been seeing colors show up in Firefox mochitests... fun!

Cool! I'm looking forward to getting this in.

-- Simen






  parent reply	other threads:[~2017-04-22 15:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25  8:06 bug#25525: 25.1.90; add color highlighting to css mode Tom Tromey
2017-01-25 15:51 ` Eli Zaretskii
2017-01-25 17:25   ` Tom Tromey
2017-01-25 23:34     ` Tom Tromey
2017-01-26 16:05       ` Eli Zaretskii
2017-01-26 17:13         ` Tom Tromey
2017-01-26 19:32           ` Eli Zaretskii
2017-02-11  4:11             ` Tom Tromey
2017-01-26 17:17         ` Tom Tromey
2017-01-25 16:52 ` Glenn Morris
2017-01-25 20:23 ` Simen Heggestøyl
2017-01-25 20:41   ` Tom Tromey
2017-01-25 23:24   ` Tom Tromey
2017-01-26 18:25     ` Simen Heggestøyl
2017-02-11  4:16       ` Tom Tromey
2017-02-11 15:17       ` Tom Tromey
2017-02-17 19:29         ` Simen Heggestøyl
2017-03-04 17:55           ` Tom Tromey
2017-03-04 18:46             ` Simen Heggestøyl
2017-03-04 19:58               ` Tom Tromey
2017-03-05 18:28                 ` Simen Heggestøyl
     [not found]                   ` <871str3b48.fsf@tromey.com>
2017-03-20 21:28                     ` Tom Tromey
2017-03-22 22:07                     ` Tom Tromey
2017-03-29 18:27                       ` Simen Heggestøyl
2017-04-21  3:40                         ` Tom Tromey
2017-04-21  9:33                           ` Andreas Schwab
2017-04-22  0:44                             ` Tom Tromey
2017-04-22 15:07                           ` Simen Heggestøyl [this message]
2017-04-24 13:44                             ` Tom Tromey
2017-04-29  4:17                               ` Tom Tromey
2017-05-01 19:15                                 ` Simen Heggestøyl
2017-05-03 22:04                                   ` Tom Tromey
2017-05-01 21:25                                 ` Etienne Prud’homme
2017-05-03 22:03                                   ` Tom Tromey
2017-05-03 23:24                                     ` Etienne Prud’homme
2017-05-04  3:51                                       ` Tom Tromey
2017-03-05  2:42               ` Tom Tromey
2017-03-05 15:34                 ` Eli Zaretskii
2017-05-03 22:04 ` bug#25525: done Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492873665.3376.0@smtp.gmail.com \
    --to=simenheg@gmail.com \
    --cc=25525@debbugs.gnu.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).