From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Wed, 29 Mar 2017 20:27:36 +0200 Message-ID: <1490812056.14782.1@smtp.gmail.com> References: <87mvefh8br.fsf@tromey.com> <1485375833.1960.0@smtp.gmail.com> <1485455113.4245.1@smtp.gmail.com> <1487359774.1998.0@smtp.gmail.com> <1488653191.6153.0@smtp.gmail.com> <1488738524.13864.0@smtp.gmail.com> <871str3b48.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Trace: blaine.gmane.org 1490812108 31534 195.159.176.226 (29 Mar 2017 18:28:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 29 Mar 2017 18:28:28 +0000 (UTC) Cc: 25525@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 29 20:28:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctIKF-0006CC-O5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Mar 2017 20:28:07 +0200 Original-Received: from localhost ([::1]:60347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctIKL-00057v-Jk for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Mar 2017 14:28:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctIKG-00057h-BF for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2017 14:28:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctIKA-0004I3-Cf for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2017 14:28:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctIKA-0004Hv-9h for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2017 14:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ctIK9-0001e7-Vm for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2017 14:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Mar 2017 18:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.14908120676302 (code B ref 25525); Wed, 29 Mar 2017 18:28:01 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 29 Mar 2017 18:27:47 +0000 Original-Received: from localhost ([127.0.0.1]:51577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctIJv-0001da-A6 for submit@debbugs.gnu.org; Wed, 29 Mar 2017 14:27:47 -0400 Original-Received: from mail-lf0-f53.google.com ([209.85.215.53]:35613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctIJt-0001dN-Ln for 25525@debbugs.gnu.org; Wed, 29 Mar 2017 14:27:46 -0400 Original-Received: by mail-lf0-f53.google.com with SMTP id j90so14342937lfk.2 for <25525@debbugs.gnu.org>; Wed, 29 Mar 2017 11:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=D5owC5YC5do37tShowzL1WHzFCxZsCkq5rKDBcGV46I=; b=Affja9nQr51BhxI2D6s6kS3qZalrHv5d6e4ChLa9k2zHvQgbhYhgwkzJ1V3zDhRN61 KUBvLXSLTFFwwlzOJPdynvej4XVkKQ9qNZg+clbyD2Bsm65OGTXtB7HrZLR2q2bzQquI 5ZSIPAwFbcQCikgu/NDFK4WzAe15PqLCG0B7sIb1P6tWlPG91SVNh0sXsZnY4etRy4Rf sHNSY1E9dSX1phThpWjXOy7+0VapNQeA5U2ItMGR6XJLGKBcU1YpzwZELT6veAfebp6t dqAMlsHkOlQ2UqXIJnuR5v8yUpkBdrNwFS1WeYKtbAoxPNKu/Davp+hQWMYVAiHEZHJW 4pJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=D5owC5YC5do37tShowzL1WHzFCxZsCkq5rKDBcGV46I=; b=kU9qfdAlu1audr1HQr7Efc964f2+DQh7XP+c2AtRGXG+fRU4kS01GoS8cHNMDc0kdd EIeRJJVK5+nylB19C6fn5MpNj5vbUnp6hYOYtuJqy/oQql8cBwcExIB9cmZaCk5t/f7O 3yqoR0+WVRFONQ/ElsZY6IHBq+AW91nm78MRpzXSiX0DatRA3hCZ04ZGiybcZqdXF+ED FOKH2bP3TCyhPvjKxw+IsE3oW3v5qbUY+Ru6UNM1/eguQflBuQPzIOmXfl+H/S+Co5mV thhITdOEwTaVrYJdpZuYw9DzyeK1VVlfyOz7r+TnKi54yrwOrcgR73AX+ETIvFqHNkR8 4q5w== X-Gm-Message-State: AFeK/H3AF35g8fvpUAojDjr1agx3gAPFmkCgbcHW84t7JoQaDCEKmGfqXobw8Y2buP8hNg== X-Received: by 10.46.14.17 with SMTP id 17mr689834ljo.40.1490812059696; Wed, 29 Mar 2017 11:27:39 -0700 (PDT) Original-Received: from [192.168.100.9] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id t125sm1426323lff.31.2017.03.29.11.27.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Mar 2017 11:27:38 -0700 (PDT) In-Reply-To: <87poh90xui.fsf@tromey.com> X-Mailer: geary/0.11.3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131067 Archived-At: > I just tried my patch and "$black" is not highlighted here in scss mode. > I think that's expected, now that I look at it, because > css--colors-regexp starts with a "\_<", so it only matches at symbol > boundaries. Hm, I'm still seeing it here with the patch from March 4. Maybe that one is outdated? > On second thought, I suppose checking backward one word isn't such a big > deal. I don't know SCSS though. Is @mixin the only problem case or are > there others? I think the names of mixins and placeholders are most important, because it's not unlikely for them to have colors for names. Examples of usage: @mixin black {} .foo { @include black; } %black {} .foo { @extend %black; } There's also maps, but I think they're less important if it's hard to solve: $foo: (bar: 1, black: 2); -- Simen