From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Sat, 04 Mar 2017 19:46:31 +0100 Message-ID: <1488653191.6153.0@smtp.gmail.com> References: <87mvefh8br.fsf@tromey.com> <1485375833.1960.0@smtp.gmail.com> <1485455113.4245.1@smtp.gmail.com> <1487359774.1998.0@smtp.gmail.com> <"Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Fri, 17 Feb 2017 20:29:34 +0100"> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Trace: blaine.gmane.org 1488653242 15031 195.159.176.226 (4 Mar 2017 18:47:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 4 Mar 2017 18:47:22 +0000 (UTC) Cc: 25525@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 04 19:47:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckEhx-0002Yv-QL for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Mar 2017 19:47:09 +0100 Original-Received: from localhost ([::1]:36256 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEi1-0004sB-WF for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Mar 2017 13:47:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEht-0004s2-JF for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 13:47:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckEhq-0002Fq-HD for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 13:47:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42043) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckEhq-0002Fg-Cl for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 13:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ckEhq-0003uw-2V for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 13:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2017 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.148865320315026 (code B ref 25525); Sat, 04 Mar 2017 18:47:02 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 4 Mar 2017 18:46:43 +0000 Original-Received: from localhost ([127.0.0.1]:40242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckEhX-0003uI-6m for submit@debbugs.gnu.org; Sat, 04 Mar 2017 13:46:43 -0500 Original-Received: from mail-lf0-f47.google.com ([209.85.215.47]:36807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckEhU-0003u3-De for 25525@debbugs.gnu.org; Sat, 04 Mar 2017 13:46:40 -0500 Original-Received: by mail-lf0-f47.google.com with SMTP id y193so58726213lfd.3 for <25525@debbugs.gnu.org>; Sat, 04 Mar 2017 10:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=EG0CQylt2NJ253fDOHt4YeOVANltiTIkzXv65be04Uw=; b=VykcWfQHSa2gvh+f2vW4Z65MVfXeDWMIhnNKuOdmWhr9uii4oH7/sCRaB9Wryk9KUj 5XM7nHUS4AC8KnfeuLODs6UETTHedm3Ntt4/16Wm/pR8ztdP+cRvCGrFhk3h2NpGfyqH 3CC0Sp5A7Jep1SSVhGlQ8TIairlfu2N4lbLN2gAWPAsjK6yWdCwPQZFILh8KE3SPPBT6 1RvH7bmL7e6n4/k1n50LZQnHg7fW+BnbyoY3lsQUsbJRF2zeA5FuA+A3zLCXyrKAyFNG uPMHZfp1meEXsaePbeClZAcMuQO4+tGl2+sxh9MFy8djeldcmP5xOHMM1xi+/l29DOgd CyDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=EG0CQylt2NJ253fDOHt4YeOVANltiTIkzXv65be04Uw=; b=RizFoSvChmamg3h2m4hPto4kYcunq+kgUORG1E5Px7bqG5vlt5mLPY3oBPW3wvMK7Z aEuZ7XCdLG7Mi/63SBa0gZ3+KVYzl/VxctSUIG5J8EDJg/WjLCqYJuGBVQTu3NZbA+mp yDMJnrrn+zMf8KI05Jcit+PzOD23OCAyLHrE4wv9o1T7PO85onGS9Zx20VjTPmuO1O4w aGMasNZUvaO/BMw+6YGKd4togro+GjYmY5VvNAm6XKXNPUbaYHPIZyGfmzNkmymFcqY5 RKupSUen3BDZDSs8FUm6plcJJ+Ji88GCsfKZxmD4qJes3NEye/OcAB0j/FEI8ZcCHNFo YTag== X-Gm-Message-State: AMke39ki/d9IKkW/m8QWi0awAsx8vOfzI2u+VmAJVnoBSMtJOT7d4kT+x0lI4x98bFmVAw== X-Received: by 10.46.83.88 with SMTP id t24mr2999441ljd.20.1488653194198; Sat, 04 Mar 2017 10:46:34 -0800 (PST) Original-Received: from [192.168.100.9] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id n20sm3009568lfb.53.2017.03.04.10.46.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Mar 2017 10:46:33 -0800 (PST) In-Reply-To: <87a891j59a.fsf@tromey.com> X-Mailer: geary/0.11.3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130196 Archived-At: On Sat, Mar 4, 2017 at 6:55 PM, Tom Tromey wrote: > I was able to reproduce the problem and I think I found the bug: > css--fontify-region was not respecting any region extension done by > font-lock-default-fontify-region, but this is what extended > fontification to include the whole line containing point when > searching. > > Please try this version. Nice, that seems to have fixed the bug! I found another one: in SCSS mode, when using the `rgba` function where one argument is a variable, subsequent colors aren't highlighted. An example: body { color: #ddd; color: rgba($color-var, 1); color: #abc; // Not highlighted } There is also a test failure when you rebase the patch on the latest master due to the changes in 7b00e956b4. It can be fixed by passing 2 as the last argument to `color-rgb-to-hex' in `css--hsl-color'. -- Simen