From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Wed, 25 Jan 2017 21:23:53 +0100 Message-ID: <1485375833.1960.0@smtp.gmail.com> References: <87mvefh8br.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Trace: blaine.gmane.org 1485375934 25142 195.159.176.226 (25 Jan 2017 20:25:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 25 Jan 2017 20:25:34 +0000 (UTC) Cc: 25525@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 25 21:25:29 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWU7x-0004g6-Ja for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jan 2017 21:25:09 +0100 Original-Received: from localhost ([::1]:34370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWU82-0000hS-O1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jan 2017 15:25:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWU7t-0000eM-80 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 15:25:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWU7q-0001iw-0A for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 15:25:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWU7p-0001is-Sq for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 15:25:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cWU7p-0004Yv-Nt for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 15:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2017 20:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.148537584417470 (code B ref 25525); Wed, 25 Jan 2017 20:25:01 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 25 Jan 2017 20:24:04 +0000 Original-Received: from localhost ([127.0.0.1]:43535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWU6u-0004Xi-LQ for submit@debbugs.gnu.org; Wed, 25 Jan 2017 15:24:04 -0500 Original-Received: from mail-lf0-f42.google.com ([209.85.215.42]:34925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWU6s-0004WF-NQ for 25525@debbugs.gnu.org; Wed, 25 Jan 2017 15:24:03 -0500 Original-Received: by mail-lf0-f42.google.com with SMTP id n124so134871110lfd.2 for <25525@debbugs.gnu.org>; Wed, 25 Jan 2017 12:24:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=Vx6zmlYWv7zfRYfIRcUVk7slcsKYGQfAYwyDUK6j/MY=; b=OCajDgEWcf7LGsP49TWS0/DYEuDYt0FLhun3cwpv3YqJCXQGj50BVOshZw29T64b3r dqICDHOp71Wn9jhzlaqFCpt9iihyptRXDl2dbb1VpqcHO/Il+sXpDELfLNtIQiJUckR0 /xbBLKrxs+qM3rzvEfYAUZR2TsnybUqDB7IpDaLkpBArdkqWEyRgDT/8mTghkAYvWEnd rJQhXZ2BDWbY0ngBGvHW3bfredSmRPPFkXrMjXjrAlFAnwLiAY5B3md60UE0HiTSIWEd aIMO0Zl5rvyeukTL715oh7UtAQx1xiYoU074N2GOc0NBp/6YEpQ3HWQCRnlJqqOSrlZl EeYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=Vx6zmlYWv7zfRYfIRcUVk7slcsKYGQfAYwyDUK6j/MY=; b=CbcSKL4Egsdqu6yO2sCotwG4+YlaJbtiDv3PZdvCqJrLGAPnkbYSRO1mRm8R+3pcJ0 Y1PDjbCsgPVZ1YrW9yvdFheIT55D+X0EidlIx//9vbygSW4djpMgZHl5vNNLsgNVgubp ibnlSsJyQs2yIvcz8+acrBAFNcaiuBeCGYlTG8hpYhJDLk2ufyncsBMRWrWU9EGLjA9N qnfmM1uhkUuCk5zKpNdPCDXhGCXKNDZDQs8VQv+ym/4OzIw2td9U/JV7epM/V3Y6MoIg IwqrhGlIwpJiucmNiuKcX7asXMNq6Qegsvco8C3Mb9vgli8XzSeuLAjIuvqSLubtTezB CpTQ== X-Gm-Message-State: AIkVDXLLYKY1X/3PckSBaRJThm5jV93LBkBkUpYxX3uFnpF0OQPcIckAjeDprfsHpGsB5w== X-Received: by 10.46.71.203 with SMTP id u194mr15514407lja.7.1485375836259; Wed, 25 Jan 2017 12:23:56 -0800 (PST) Original-Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id u126sm8622489lja.25.2017.01.25.12.23.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jan 2017 12:23:55 -0800 (PST) In-Reply-To: <87mvefh8br.fsf@tromey.com> X-Mailer: geary/0.11.3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128487 Archived-At: Thanks Tom, this looks to be a very nice addition to CSS mode! Some comments: - It should be possible to disable it. I'm not sure whether it should be turned on by default or not, though I'd think that most CSS developers will find it useful. - Selectors that happen to contain the name of a color are highlighted. The 'red' part of '.centered-button' is highlighted in red, for instance. - The same goes for variable names in both CSS and SCSS. - Property names are also highlighted, for instance in the case of the 'white-space' property. - There's a stray call to 'message' in the beginning of 'css--fontify-colors'. - The error message in 'css--compute-color' should be capitalized. - I think it deserves a NEWS entry. -- Simen